ci: add golden files for runtime error codes#44677
Closed
AndrewKushnir wants to merge 1 commit intoangular:masterfrom
Closed
ci: add golden files for runtime error codes#44677AndrewKushnir wants to merge 1 commit intoangular:masterfrom
AndrewKushnir wants to merge 1 commit intoangular:masterfrom
Conversation
Runtime error codes in the Core, Common and Forms packages were not included into the `public-api` group reviews. This commit creates the necessary golden files to keep track of further changes in the runtime codes. This is a followup from angular#44398 (comment).
atscott
approved these changes
Jan 10, 2022
Contributor
atscott
left a comment
There was a problem hiding this comment.
reviewed-for: public-api
jessicajaniuk
approved these changes
Jan 11, 2022
Contributor
jessicajaniuk
left a comment
There was a problem hiding this comment.
LGTM 🍪
reviewed-for: public-api
dylhunn
approved these changes
Jan 11, 2022
Contributor
dylhunn
left a comment
There was a problem hiding this comment.
reviewed-for: public-api
devversion
approved these changes
Jan 12, 2022
Contributor
|
This PR was merged into the repository by commit 57d0ca1. |
atscott
pushed a commit
that referenced
this pull request
Jan 12, 2022
Runtime error codes in the Core, Common and Forms packages were not included into the `public-api` group reviews. This commit creates the necessary golden files to keep track of further changes in the runtime codes. This is a followup from #44398 (comment). PR Close #44677
amitbeck
pushed a commit
to amitbeck/angular
that referenced
this pull request
Jan 13, 2022
Runtime error codes in the Core, Common and Forms packages were not included into the `public-api` group reviews. This commit creates the necessary golden files to keep track of further changes in the runtime codes. This is a followup from angular#44398 (comment). PR Close angular#44677
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Runtime error codes in the Core, Common and Forms packages were not included into the
public-apigroup reviews. This commit creates the necessary golden files to keep track of further changes in the runtime codes.This is a followup from #44398 (comment).
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?