fix(ivy): ensure that super/sub classes can both update an animation binding in harmony#29978
fix(ivy): ensure that super/sub classes can both update an animation binding in harmony#29978matsko wants to merge 1 commit intoangular:masterfrom
Conversation
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
195a4a1 to
f997d07
Compare
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
f997d07 to
db4e609
Compare
There was a problem hiding this comment.
Won't fromState always be truthy now? Is that intended?
4444cc1 to
327532c
Compare
|
You can preview 195a4a1 at https://pr29978-195a4a1.ngbuilds.io/. |
327532c to
3f6bf6d
Compare
…binding in harmony In ivy, because metadata is inherited, this may cause super and sub host bindings on two components to update an animation binding in parallel. This patch ensures that the animation transition code can handle this. Jira-Issue: FW-1220
|
You can preview 3f6bf6d at https://pr29978-3f6bf6d.ngbuilds.io/. |
|
You can preview ab6b89a at https://pr29978-ab6b89a.ngbuilds.io/. |
|
Is this superceded by #30022? |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
In ivy, because metadata is inherited, this may cause super and sub host bindings on
two components to update an animation binding in parallel. This patch ensures that
the animation transition code can handle this.
Jira-Issue: FW-1220