fix(common): properly check NaN value (#22305)

trotyl · benlesh · commit 3f6bf6dfd166 · 2019-04-19T19:36:39.000-07:00
closes #15721 PR Close #22305
diff --git a/packages/common/src/pipes/async_pipe.ts b/packages/common/src/pipes/async_pipe.ts
@@ -6,7 +6,7 @@
  * found in the LICENSE file at https://angular.io/license
  */
 
-import {ChangeDetectorRef, EventEmitter, Injectable, OnDestroy, Pipe, PipeTransform, WrappedValue, ɵisObservable, ɵisPromise} from '@angular/core';
+import {ChangeDetectorRef, EventEmitter, Injectable, OnDestroy, Pipe, PipeTransform, WrappedValue, ɵisObservable, ɵisPromise, ɵlooseIdentical} from '@angular/core';
 import {Observable, SubscriptionLike} from 'rxjs';
 import {invalidPipeArgumentError} from './invalid_pipe_argument_error';
 
@@ -103,7 +103,7 @@ export class AsyncPipe implements OnDestroy, PipeTransform {
       return this.transform(obj as any);
     }
 
-    if (this._latestValue === this._latestReturnedValue) {
+    if (ɵlooseIdentical(this._latestValue, this._latestReturnedValue)) {
       return this._latestReturnedValue;
     }
 
diff --git a/packages/common/test/pipes/async_pipe_spec.ts b/packages/common/test/pipes/async_pipe_spec.ts
@@ -82,6 +82,18 @@ import {SpyChangeDetectorRef} from '../spies';
                async.done();
              }, 10);
            }));
+
+        it('should return unwrapped value for unchanged NaN', () => {
+          const emitter = new EventEmitter<any>();
+          emitter.emit(null);
+          pipe.transform(emitter);
+          emitter.next(NaN);
+          const firstResult = pipe.transform(emitter);
+          const secondResult = pipe.transform(emitter);
+          expect(firstResult instanceof WrappedValue).toBe(true);
+          expect((firstResult as WrappedValue).wrapped).toBeNaN();
+          expect(secondResult).toBeNaN();
+        });
       });
 
       describe('ngOnDestroy', () => {

Original file line number	Diff line number	Diff line change
`@@ -6,7 +6,7 @@`
`6`	`6`	`* found in the LICENSE file at https://angular.io/license`
`7`	`7`	`*/`
`8`	`8`
`9`		`-import {ChangeDetectorRef, EventEmitter, Injectable, OnDestroy, Pipe, PipeTransform, WrappedValue, ɵisObservable, ɵisPromise} from '@angular/core';`
	`9`	`+import {ChangeDetectorRef, EventEmitter, Injectable, OnDestroy, Pipe, PipeTransform, WrappedValue, ɵisObservable, ɵisPromise, ɵlooseIdentical} from '@angular/core';`
`10`	`10`	`import {Observable, SubscriptionLike} from 'rxjs';`
`11`	`11`	`import {invalidPipeArgumentError} from './invalid_pipe_argument_error';`
`12`	`12`
`@@ -103,7 +103,7 @@ export class AsyncPipe implements OnDestroy, PipeTransform {`
`103`	`103`	`return this.transform(obj as any);`
`104`	`104`	`}`
`105`	`105`
`106`		`- if (this._latestValue === this._latestReturnedValue) {`
	`106`	`+ if (ɵlooseIdentical(this._latestValue, this._latestReturnedValue)) {`
`107`	`107`	`return this._latestReturnedValue;`
`108`	`108`	`}`
`109`	`109`