fix(ivy): ensure that super/sub classes can both update an animation binding in harmony#30022
Closed
matsko wants to merge 1 commit intoangular:masterfrom
Closed
fix(ivy): ensure that super/sub classes can both update an animation binding in harmony#30022matsko wants to merge 1 commit intoangular:masterfrom
matsko wants to merge 1 commit intoangular:masterfrom
Conversation
ab6b89a to
73554d4
Compare
kara
reviewed
Apr 22, 2019
Contributor
There was a problem hiding this comment.
Looks like the comment no longer matches the code (since there isn't a "removal arc" anymore). Can you update it (maybe add why this is no longer a problem)?
Contributor
|
@matsko ... pssstt... don't forget to add labels so you don't end up in primary triage. :) |
mhevery
approved these changes
Apr 22, 2019
Contributor
73554d4 to
e0ff360
Compare
Contributor
Author
0486642 to
15b3b91
Compare
15b3b91 to
203b597
Compare
Contributor
Author
16 tasks
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In ivy, because metadata is inherited, this may cause super and sub host bindings on
two components to update an animation binding in parallel. This patch ensures that
the animation transition code can handle this.
Jira-Issue: FW-1220