Skip to content

ci: cache Material node_modules based on the lockfile checksum#29417

Closed
gkalpak wants to merge 1 commit intoangular:masterfrom
gkalpak:ci-cache-material-on-lockfile
Closed

ci: cache Material node_modules based on the lockfile checksum#29417
gkalpak wants to merge 1 commit intoangular:masterfrom
gkalpak:ci-cache-material-on-lockfile

Conversation

@gkalpak
Copy link
Member

@gkalpak gkalpak commented Mar 20, 2019 •
edited
Loading

This will increase the cache hit rate for the material-unit-tests job.

Builds on top of #29416.

@gkalpak gkalpak requested a review from a team March 20, 2019 13:39
@gkalpak gkalpak added action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project state: blocked target: patch This PR is targeted for the next patch release labels Mar 20, 2019
@ngbot ngbot bot modified the milestone: needsTriage Mar 20, 2019
@googlebot
Copy link

googlebot commented Mar 20, 2019

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

ℹ️ Googlers: Go here for more info.

@gkalpak gkalpak force-pushed the ci-cache-material-on-lockfile branch from bef05e2 to 5c787ce Compare March 20, 2019 13:41
@gkalpak gkalpak mentioned this pull request Mar 20, 2019
Closed
@gkalpak gkalpak force-pushed the ci-cache-material-on-lockfile branch from 5c787ce to 4a0fad2 Compare March 20, 2019 13:47
@gkalpak
ci: cache Material node_modules based on the lockfile checksum
e1dc671 
This will increase the cache hit rate for the `material-unit-tests` job.
Related to angular#29416 (comment).
@gkalpak gkalpak force-pushed the ci-cache-material-on-lockfile branch from 4a0fad2 to e1dc671 Compare March 20, 2019 14:03
@googlebot
Copy link

googlebot commented Mar 20, 2019

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@matsko matsko added target: major This PR is targeted for the next major release and removed target: patch This PR is targeted for the next patch release labels Mar 20, 2019
@matsko
Copy link
Contributor

matsko commented Mar 20, 2019

@gkalpak this fails on patch. Please open a new PR and target it directly to 7.2.x

@matsko matsko closed this in fd122b0 Mar 20, 2019
@gkalpak gkalpak deleted the ci-cache-material-on-lockfile branch March 20, 2019 19:20
@gkalpak
Copy link
Member Author

gkalpak commented Mar 20, 2019

My bad. The material-unit-tests jobs does not exist on patch 😇

wKoza pushed a commit to wKoza/angular that referenced this pull request Apr 17, 2019
@gkalpak @wKoza
ci: cache Material node_modules based on the lockfile checksum (ang…
1da5eee 
…ular#29417)

This will increase the cache hit rate for the `material-unit-tests` job.
Related to angular#29416 (comment).

PR Close angular#29417
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 14, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@devversion devversion devversion approved these changes

+1 more reviewer

@filipesilva filipesilva filipesilva approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: build & ci Related the build and CI infrastructure of the project cla: yes target: major This PR is targeted for the next major release

Projects

None yet

Milestone

needsTriage

Development

Successfully merging this pull request may close these issues.

5 participants

@gkalpak @googlebot @matsko @filipesilva @devversion