ci: do not cache modified "node_modules" in "material-unit-tests" job#29416
Closed
devversion wants to merge 1 commit intoangular:masterfrom
Closed
ci: do not cache modified "node_modules" in "material-unit-tests" job#29416devversion wants to merge 1 commit intoangular:masterfrom
devversion wants to merge 1 commit intoangular:masterfrom
Conversation
Currently we cache the Material `node_modules` after the `run_angular_material_unit_tests.sh` completed. This means that the cache will incorrectly contain the Ivy NPM package output which might be incompatible with the other Material dependencies. e.g. the Material postinstall command now uses a different NGC version that does not work with the `typescript` version that has been specified in the Material project.
14 tasks
gkalpak
approved these changes
Mar 20, 2019
gkalpak
added a commit
to gkalpak/angular
that referenced
this pull request
Mar 20, 2019
This will increase the cache hit rate for the `material-unit-tests` job. Related to angular#29416 (comment).
14 tasks
wKoza
pushed a commit
to wKoza/angular
that referenced
this pull request
Apr 17, 2019
…angular#29416) Currently we cache the Material `node_modules` after the `run_angular_material_unit_tests.sh` completed. This means that the cache will incorrectly contain the Ivy NPM package output which might be incompatible with the other Material dependencies. e.g. the Material postinstall command now uses a different NGC version that does not work with the `typescript` version that has been specified in the Material project. PR Close angular#29416
wKoza
pushed a commit
to wKoza/angular
that referenced
this pull request
Apr 17, 2019
…ular#29417) This will increase the cache hit rate for the `material-unit-tests` job. Related to angular#29416 (comment). PR Close angular#29417
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes that the
material-unit-testsjob currently fails. This nowsurfaces because yesterday we rebased the
ivy-2019branchwhich now contains a
postinstallhook needed for Bazel.Currently we cache the Material
node_modulesafterthe
run_angular_material_unit_tests.shcompleted. Thismeans that the cache will incorrectly contain the Ivy NPM
package output which might be incompatible with the
other Material dependencies. e.g. the Material postinstall
command now uses a different NGC version that does not
work with the
typescriptversion that has been specified inthe Material project.