Skip to content

i18n code refactoring (intl removal)#18907

Closed
vicb wants to merge 6 commits intoangular:masterfrom
vicb:0828-i18n
Closed

i18n code refactoring (intl removal)#18907
vicb wants to merge 6 commits intoangular:masterfrom
vicb:0828-i18n

Conversation

@vicb
Copy link
Copy Markdown
Contributor

@vicb vicb commented Aug 28, 2017 •
edited
Loading

This PR consists of:

Because the PR needs to be merged one after the other. Both of them got approved.

@vicb vicb added area: i18n Issues related to localization and internationalization action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release labels Aug 28, 2017
@googlebot
Copy link
Copy Markdown

googlebot commented Aug 28, 2017

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

This was referenced Aug 28, 2017
Closed
Closed
@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Aug 28, 2017

You can preview 859b7fa at https://pr18907-859b7fa.ngbuilds.io/.

@vicb vicb removed the action: merge The PR is ready for merge by the caretaker label Aug 28, 2017
IgorMinar
IgorMinar approved these changes Aug 28, 2017
View reviewed changes
Copy link
Copy Markdown
Contributor

@IgorMinar IgorMinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm for the locals move

@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Aug 28, 2017

You can preview 6aa89fb at https://pr18907-6aa89fb.ngbuilds.io/.

@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Aug 28, 2017

You can preview c8de8e0 at https://pr18907-c8de8e0.ngbuilds.io/.

@ocombe ocombe added cla: yes and removed cla: no labels Aug 28, 2017
@vicb vicb mentioned this pull request Aug 28, 2017
Closed
@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Aug 28, 2017

You can preview bae0cc4 at https://pr18907-bae0cc4.ngbuilds.io/.

@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Aug 28, 2017

You can preview 6c222a3 at https://pr18907-6c222a3.ngbuilds.io/.

@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Aug 28, 2017

You can preview 11d0de6 at https://pr18907-11d0de6.ngbuilds.io/.

@vicb vicb added the action: merge The PR is ready for merge by the caretaker label Aug 28, 2017
@mary-poppins
Copy link
Copy Markdown

mary-poppins commented Aug 28, 2017

You can preview ae9aba4 at https://pr18907-ae9aba4.ngbuilds.io/.

@vicb
Copy link
Copy Markdown
Contributor Author

vicb commented Aug 28, 2017 •
edited
Loading

Labelled "blocked" because it should be merged in master, not in g3 (a distinct CL is ready to be merged there)

This was referenced Aug 29, 2017
Merged
Closed
@mhevery mhevery added cla: yes and removed cla: no labels Aug 29, 2017
@mhevery mhevery closed this in 4c45347 Aug 29, 2017
mhevery pushed a commit that referenced this pull request Aug 29, 2017
@vicb @mhevery
refactor(common): refactor i18n code to ease tree shaking (#18907)
832876d 
PR Close #18907
mhevery pushed a commit that referenced this pull request Aug 29, 2017
@vicb @mhevery
refactor(common): update generated i18n data (#18907)
6970396 
PR Close #18907
mhevery pushed a commit that referenced this pull request Aug 29, 2017
@vicb @mhevery
refactor: generate i18n files in common/locales (#18907)
535c7bb 
PR Close #18907
mhevery pushed a commit that referenced this pull request Aug 29, 2017
@vicb @mhevery
refactor(common): move generated locale files (#18907)
4c5aac8 
PR Close #18907
mhevery pushed a commit that referenced this pull request Aug 29, 2017
@ocombe @mhevery
feat(common): generate closure-locale.ts to tree shake locale data (#…
4878936 
…18907)

Closure will only keep the data for the locale defined in `goog.LOCALE`

PR Close #18907
@vicb vicb deleted the 0828-i18n branch September 19, 2017 18:45
@angular-automatic-lock-bot
Copy link
Copy Markdown

angular-automatic-lock-bot bot commented Sep 12, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@IgorMinar IgorMinar IgorMinar approved these changes

@ocombe ocombe ocombe approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker area: i18n Issues related to localization and internationalization cla: yes state: blocked target: major This PR is targeted for the next major release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@vicb @googlebot @mary-poppins @IgorMinar @ocombe @mhevery