refactor(common): remove AVAILABLE_LOCALES#18868
Closed
ocombe wants to merge 1 commit intoangular:masterfrom
Closed
refactor(common): remove AVAILABLE_LOCALES#18868ocombe wants to merge 1 commit intoangular:masterfrom
AVAILABLE_LOCALES#18868ocombe wants to merge 1 commit intoangular:masterfrom
Conversation
|
You can preview 35b9f3c at https://pr18868-35b9f3c.ngbuilds.io/. |
vicb
approved these changes
Aug 24, 2017
35b9f3c to
dd82b64
Compare
|
You can preview dd82b64 at https://pr18868-dd82b64.ngbuilds.io/. |
Contributor
|
Note: missing approval from @IgorMinar or @mhevery. |
IgorMinar
approved these changes
Aug 28, 2017
Contributor
|
will be merged via #18907 |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
We added
AVAILABLE_LOCALESin the intl PR but we don't really need it.Issue Number: #18855
What is the new behavior?
Removed
AVAILABLE_LOCALESthat was not necessaryDoes this PR introduce a breaking change?