Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: angular/angular
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 13.3.7
Choose a base ref
...
head repository: angular/angular
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 13.3.8
Choose a head ref
  • 5 commits
  • 13 files changed
  • 4 contributors

Commits on May 12, 2022

  1. fix(docs-infra): do not detect a running job as failed (#45948) 

    Previously, the preview server would incorrectly identify a running
`aio_preview` CI job as failed and therefore skip creating a preview.
This happened because it only checked whether the job's status is
`success`, failing to account for the fact that the job would have a
`running` status.
(This bug was accidentally introduced in #45934.)

This commit avoids the problem by getting rid of the job status check
altogether. This check does not offer any benefit, since the CI job will
always be in a `running` state (i.e. neither successfully completed nor
failed).

PR Close #45948
    @gkalpak @thePunderWoman
    gkalpak authored and thePunderWoman committed May 12, 2022
    Configuration menu
    Copy the full SHA
    e223649 View commit details
    Browse the repository at this point in the history

  2. fix(language-service): Prevent TSServer from removing templates from … 

    …project (#45965)

As part of the `updateProjectIfDirty` process and inside `updateNonInferredProjectFiles`
TS Server will remove the template files that we added as roots in
`readResource`.
https://sourcegraph.com/github.com/microsoft/TypeScript@c300fea3250abd7f75920d95a58d9e742ac730ee/-/blob/src/server/editorServices.ts?L2363

The external files are added to the list here so ensuring that the
templates are included in the `getExternalFiles` will prevent this from
happening
https://sourcegraph.com/github.com/microsoft/TypeScript@c300fea3250abd7f75920d95a58d9e742ac730ee/-/blob/src/server/editorServices.ts?L2395:18

PR Close #45965
    @atscott @thePunderWoman
    atscott authored and thePunderWoman committed May 12, 2022
    Configuration menu
    Copy the full SHA
    b4eb9ed View commit details
    Browse the repository at this point in the history

  3. build: set the default branch of the ephemeral repo for publishing bu… 

    …ild artifacts to main (#45974)

It looks like because the primary branch for our ephemeral repos doesn't match the build repos
we are pushing to it causes errors around shallow clones.  This attempts to prevent this.

PR Close #45974
    @josephperrott @thePunderWoman
    josephperrott authored and thePunderWoman committed May 12, 2022
    Configuration menu
    Copy the full SHA
    90e6987 View commit details
    Browse the repository at this point in the history

  4. build: use clone instead of init for creating the builds commit chang… 

    …es (#45975)

Rather than using git init to create an empty repo and then shallow fetch the
repo for a specific branch, we shallow clone the repository itself for the branch.
This prevents us from running into the issue of Github denying the push because it
comes from a shallow branch which does not map back to the repository.

PR Close #45975
    @josephperrott @thePunderWoman
    josephperrott authored and thePunderWoman committed May 12, 2022
    Configuration menu
    Copy the full SHA
    c9c24d1 View commit details
    Browse the repository at this point in the history

  5. release: cut the v13.3.8 release (#45976)

    @jessicajaniuk
    jessicajaniuk authored May 12, 2022
    Configuration menu
    Copy the full SHA
    986e80e View commit details
    Browse the repository at this point in the history
Loading