fix(docs-infra): do not detect a running job as failed#45948
Closed
gkalpak wants to merge 1 commit intoangular:mainfrom
Closed
fix(docs-infra): do not detect a running job as failed#45948gkalpak wants to merge 1 commit intoangular:mainfrom
gkalpak wants to merge 1 commit intoangular:mainfrom
Conversation
Previously, the preview server would incorrectly identify a running `aio_preview` CI job as failed and therefore skip creating a preview. This happened because it only checked whether the job's status is `success`, failing to account for the fact that the job would have a `running` status. (This bug was accidentally introduced in angular#45934.) This commit avoids the problem by getting rid of the job status check altogether. This check does not offer any benefit, since the CI job will always be in a `running` state (i.e. neither successfully completed nor failed).
|
You can preview 936bab2 at https://pr45948-936bab2.ngbuilds.io/. |
dylhunn
approved these changes
May 11, 2022
Contributor
|
This PR was merged into the repository by commit aea7b98. |
jessicajaniuk
pushed a commit
that referenced
this pull request
May 12, 2022
Previously, the preview server would incorrectly identify a running `aio_preview` CI job as failed and therefore skip creating a preview. This happened because it only checked whether the job's status is `success`, failing to account for the fact that the job would have a `running` status. (This bug was accidentally introduced in #45934.) This commit avoids the problem by getting rid of the job status check altogether. This check does not offer any benefit, since the CI job will always be in a `running` state (i.e. neither successfully completed nor failed). PR Close #45948
jessicajaniuk
pushed a commit
that referenced
this pull request
May 12, 2022
Previously, the preview server would incorrectly identify a running `aio_preview` CI job as failed and therefore skip creating a preview. This happened because it only checked whether the job's status is `success`, failing to account for the fact that the job would have a `running` status. (This bug was accidentally introduced in #45934.) This commit avoids the problem by getting rid of the job status check altogether. This check does not offer any benefit, since the CI job will always be in a `running` state (i.e. neither successfully completed nor failed). PR Close #45948
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the preview server would incorrectly identify a running
aio_previewCI job as failed and therefore skip creating a preview. This happened because it only checked whether the job's status issuccess, failing to account for the fact that the job would have arunningstatus.(This bug was accidentally introduced in #45934.)
This commit avoids the problem by getting rid of the job status check altogether. This check does not offer any benefit, since the CI job will always be in a
runningstate (i.e. neither successfully completed nor failed).