build: use clone instead of init for creating the builds commit changes#45975
Closed
josephperrott wants to merge 1 commit intoangular:mainfrom
Closed
build: use clone instead of init for creating the builds commit changes#45975josephperrott wants to merge 1 commit intoangular:mainfrom
josephperrott wants to merge 1 commit intoangular:mainfrom
Conversation
Rather than using git init to create an empty repo and then shallow fetch the repo for a specific branch, we shallow clone the repository itself for the branch. This prevents us from running into the issue of Github denying the push because it comes from a shallow branch which does not map back to the repository.
josephperrott
commented
May 12, 2022
|
|
||
| BUILD_REPO="${COMPONENT}-builds" | ||
| REPO_DIR="tmp/${BUILD_REPO}" | ||
| REPO_DIR="$(pwd)/tmp/${BUILD_REPO}" |
Member
Author
There was a problem hiding this comment.
It seems much safer to use an absolute path instead of relative path for referencing the directory?
Member
There was a problem hiding this comment.
Yeah, also a little more clear
devversion
approved these changes
May 12, 2022
Member
devversion
left a comment
There was a problem hiding this comment.
haha I think I remember that code
jessicajaniuk
approved these changes
May 12, 2022
Contributor
|
This PR was merged into the repository by commit 0db2841. |
jessicajaniuk
pushed a commit
that referenced
this pull request
May 12, 2022
…es (#45975) Rather than using git init to create an empty repo and then shallow fetch the repo for a specific branch, we shallow clone the repository itself for the branch. This prevents us from running into the issue of Github denying the push because it comes from a shallow branch which does not map back to the repository. PR Close #45975
jessicajaniuk
pushed a commit
that referenced
this pull request
May 12, 2022
…es (#45975) Rather than using git init to create an empty repo and then shallow fetch the repo for a specific branch, we shallow clone the repository itself for the branch. This prevents us from running into the issue of Github denying the push because it comes from a shallow branch which does not map back to the repository. PR Close #45975
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rather than using git init to create an empty repo and then shallow fetch the
repo for a specific branch, we shallow clone the repository itself for the branch.
This prevents us from running into the issue of Github denying the push because it
comes from a shallow branch which does not map back to the repository.