This repository was archived by the owner on Feb 26, 2023. It is now read-only.
Refactor holders which decorate another holder #1352
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Why don't you keep ReceiverRegistrationHolder generic ? It prevent us from casting and clearly state that the holder must implement HasReceiverRegistration.
Member
Author
There was a problem hiding this comment.
OK, i'll add back the type parameter.
Contributor
|
I'm okay with the purpose of this PR but I would have kept |
69002c5 to
e16139d
Compare
Member
Author
|
I addressed your review comment. |
yDelouis
added a commit
that referenced
this pull request
Apr 6, 2015
Refactor holders which decorate another holder
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains one commit which was split off from #1294.