Skip to content
This repository was archived by the owner on Feb 26, 2023. It is now read-only.

Fix for Parcelable[] ClassCastException #1294

Merged
yDelouis merged 2 commits into from
Apr 5, 2015
Merged

Fix for Parcelable[] ClassCastException #1294

yDelouis merged 2 commits into from
Apr 5, 2015

Conversation

@WonderCsabo
Copy link
Member

@WonderCsabo WonderCsabo commented Dec 27, 2014

Fixes #1208.

@WonderCsabo WonderCsabo force-pushed the 1208_getParcelableArray branch 6 times, most recently from c94ba98 to f0feb19 Compare December 28, 2014 14:23
@WonderCsabo WonderCsabo mentioned this pull request Jan 5, 2015
Closed
@WonderCsabo WonderCsabo force-pushed the 1208_getParcelableArray branch from f0feb19 to b89aba7 Compare March 22, 2015 15:23
@WonderCsabo
Copy link
Member Author

WonderCsabo commented Mar 22, 2015

@yDelouis please review this PR.

@WonderCsabo WonderCsabo force-pushed the 1208_getParcelableArray branch from b89aba7 to 9cc165e Compare March 22, 2015 16:21
@yDelouis
Copy link
Contributor

yDelouis commented Mar 23, 2015

Could you take into account my comment and add a test ?

@WonderCsabo
Copy link
Member Author

WonderCsabo commented Mar 24, 2015

9cc165e modifies the already existing test so it will behave like the Android code.

@yDelouis
Copy link
Contributor

yDelouis commented Mar 24, 2015

Ok, but I didn't see any test where a Parcelable array is put in a bundle and restored from it.

@WonderCsabo
Copy link
Member Author

WonderCsabo commented Mar 24, 2015

https://github.com/WonderCsabo/androidannotations/blob/9cc165ece5fadb295a05ffdbed6ac63a62e4724f/AndroidAnnotations/functional-test-1-5/src/test/java/org/androidannotations/test15/instancestate/SaveInstanceStateActivityParameterizedTest.java#L89

@yDelouis
Copy link
Contributor

yDelouis commented Mar 24, 2015

Sorry, I looked too quickly.

@WonderCsabo WonderCsabo force-pushed the 1208_getParcelableArray branch from 9cc165e to 6eedd56 Compare March 24, 2015 17:29
@WonderCsabo WonderCsabo mentioned this pull request Mar 24, 2015
Merged
@WonderCsabo WonderCsabo force-pushed the 1208_getParcelableArray branch from 6eedd56 to d8ea235 Compare March 24, 2015 17:35
@WonderCsabo
Copy link
Member Author

WonderCsabo commented Mar 24, 2015

@yDelouis i addressed your comment. I also moved 69002c5 to #1352, because that commit no longer needed for this fix, but it is still a good refactor.

@WonderCsabo WonderCsabo force-pushed the 1208_getParcelableArray branch from d8ea235 to c5cb93a Compare March 25, 2015 14:02
yDelouis added a commit that referenced this pull request Apr 5, 2015
@yDelouis
Merge pull request #1294 from WonderCsabo/1208_getParcelableArray
5767f86 
Fix for Parcelable[] ClassCastException
@yDelouis yDelouis merged commit 5767f86 into androidannotations:develop Apr 5, 2015
@yDelouis
Copy link
Contributor

yDelouis commented Apr 5, 2015

Good work. Thanks.

@yDelouis yDelouis added this to the 3.3 milestone Apr 5, 2015
@WonderCsabo WonderCsabo deleted the 1208_getParcelableArray branch April 5, 2015 21:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

3.3

Development

Successfully merging this pull request may close these issues.

ClassCastException when using @Extra with Parcelable[] objects

2 participants

@WonderCsabo @yDelouis