Merged
Conversation
dvoytenko
suggested changes
Mar 23, 2017
viewer-api/swipe-api.js
Outdated
|
|
||
|
|
||
| /** | ||
| * @typedef { |
Contributor
There was a problem hiding this comment.
@typedef {{. One { for type and the second { to declare a struct :)
viewer-api/swipe-api.js
Outdated
| /** | ||
| * @typedef { | ||
| * type: string, | ||
| * touches: Array.<TouchData>, |
viewer-api/swipe-api.js
Outdated
| * @typedef { | ||
| * type: string, | ||
| * touches: Array.<TouchData>, | ||
| * changedTouches: Array.<TouchData>, |
Contributor
There was a problem hiding this comment.
touches and changedTouches are !Array<...>|undefined, right?
viewer-api/swipe-api.js
Outdated
| * SwipeAPI is an interface the Viewer Swipe Protocol. | ||
| * @interface | ||
| */ | ||
| class SwipeAPI { |
viewer-api/swipe-api.js
Outdated
| /** | ||
| * Notify viewer that swipe touch has started. | ||
| * @param {!EventData} e | ||
| * @param {boolean} rsvp always set to false |
Contributor
There was a problem hiding this comment.
No need to pass rsvp. It's implied here since the method doesn't have any @return.
viewer-api/swipe-api.js
Outdated
| class SwipeAPI { | ||
| /** | ||
| * Notify viewer that swipe touch has started. | ||
| * @param {!EventData} e |
Contributor
There was a problem hiding this comment.
Since this is API, let's call it event.
dvoytenko
reviewed
Mar 24, 2017
| let EventData; | ||
|
|
||
| /** | ||
| * SwipeApi is an interface the Viewer Swipe Protocol. |
Contributor
There was a problem hiding this comment.
Document how to enable this protocol. I.e. #cap=swipe.
dvoytenko
reviewed
Mar 24, 2017
viewer-api/swipe-api.js
Outdated
|
|
||
| /** | ||
| * Update scroll lock state on viewer's request. When set to 'true', | ||
| * preventDefault will prevent vertical swiping. When set to 'false', |
Contributor
There was a problem hiding this comment.
Let's rewrite more conceptually: "when true - the scrolling will be locked in the document". B/c preventDefault or touch-action are implementation details which we shouldn't make promises for protocol.
dvoytenko
approved these changes
Mar 24, 2017
lironzluf
pushed a commit
to lironzluf/amphtml
that referenced
this pull request
Mar 28, 2017
* master: (34 commits) Prevent amp-carousel next/previous icons fade away on desktop (ampproject#8428) Turn on flag slidescroll-disable-css-snap” (ampproject#8436) Revert "temporarily turn off yarn (ampproject#8356)" (ampproject#8384) initial commit (ampproject#8404) Upgrades for Index Exchange amp-ad tags to report load statistics (ampproject#8054) amp-bind validation tweak (ampproject#8414) Fix an amp-instagram race condition (ampproject#8192) Use whitelist to restrict urlReplacement for scoped analytics element (ampproject#8360) Report active experiments in error logs (ampproject#8108) amp-bind: Catch exceptions in mutatedAttributesCallback (ampproject#8383) Fixing custom scroll-snap on IOS (ampproject#8391) Add experiment for using AmpContext class in integration.js (ampproject#8348) add (ampproject#8349) swipe api (ampproject#8357) skip 3 flaky tests (ampproject#8388) amp-bind: Expression complexity limit (ampproject#8321) add margin-bottom (ampproject#8350) Flying carpet: make container full viewport and center content (ampproject#8292) Service Registration: Document Click (ampproject#7882) Add a8ad (ampproject#8036) ...
mrjoro
pushed a commit
to mrjoro/amphtml
that referenced
this pull request
Apr 28, 2017
* swipe api * fix * lint * lint fix * fix * fix * fix * fix * revert * remove linter * comment update * updated documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
swipe api