Report active experiments in error logs#8108
Conversation
|
/to @lannka given the related work recently. |
src/error.js
Outdated
| url += `&jse=${detectedJsEngine}`; | ||
|
|
||
| const experiments = experimentTogglesOrNull(); | ||
| url += `&exps=${JSON.stringify(experiments)}`; |
There was a problem hiding this comment.
This would need encodeURIComponent. Would a more compact custom encoding make sense?
There was a problem hiding this comment.
Done. I also moved away from JSON to a custom format.
|
@ampprojectbot retry! |
1 similar comment
|
@ampprojectbot retry! |
|
Hi, ampproject bot here! Here are a list of the owners that can approve your files. You may leave an issue comment stating "@ampprojectbot retry!" to force me to re-evaluate this Pull Request's status
/to @alanorozco @aghassemi @cvializ @chenshay @honeybadgerdontcare @dvoytenko @ericlindley-g @erwinmombay @Gregable @lannka @mrjoro @powdercloud @newmuis @jridgewell @kmh287 @cramforce @mkhatib @camelburrito @choumx @muxin @zhouyx
|
a42f17b to
31f60dc
Compare
ee54f30 to
cadf19a
Compare
|
Hi, ampproject bot here! Here are a list of the owners that can approve your files. You may leave an issue comment stating "@ampprojectbot retry!" to force me to re-evaluate this Pull Request's status /to cramforce dvoytenko jridgewell
/to cramforce erwinmombay
/to dvoytenko jridgewell
/to aghassemi alanorozco camelburrito chenshay choumx cramforce cvializ dvoytenko ericlindley-g erwinmombay gregable honeybadgerdontcare jridgewell kmh287 lannka mkhatib mrjoro muxin newmuis powdercloud zhouyx
For any issues please file a bug at https://github.com/google/github-owners-bot/issues |
|
Hi, ampproject bot here! Here are a list of the owners that can approve your files. You may leave an issue comment stating "@ampprojectbot retry!" to force me to re-evaluate this Pull Request's status /to cramforce dvoytenko jridgewell
/to cramforce erwinmombay
/to dvoytenko jridgewell
/to alanorozco camelburrito chenshay choumx cramforce cvializ dvoytenko ericlindley-g erwinmombay gregable honeybadgerdontcare jridgewell kmh287 lannka mkhatib mrjoro muxin newmuis powdercloud zhouyx
For any issues please file a bug at https://github.com/google/github-owners-bot/issues |
| if (win.AMP_CONFIG | ||
| && Array.isArray(win.AMP_CONFIG['allow-url-opt-in']) | ||
| && win.AMP_CONFIG['allow-url-opt-in'].length > 0) { | ||
| const allowed = win.AMP_CONFIG['allow-url-opt-in']; |
There was a problem hiding this comment.
i don't see how this is related to the PR description..
is it a separate thing?
There was a problem hiding this comment.
For me to test what's actually enabled on the page, I need a centralized location of the possible url enabled experiments. Imagine a bunch of isExperimentOnAllowUrlOverride calls in the source, how would we know?
Not to mention that if we could figure something out, we would need a dependency on experiments.js in the error reporter, which I'd rather avoid.
d617eda to
531a324
Compare
|
Hi, ampproject bot here! Here are a list of the owners that can approve your files. You may leave an issue comment stating "@ampprojectbot retry!" to force me to re-evaluate this Pull Request's status /to cramforce dvoytenko jridgewell
/to cramforce erwinmombay
/to dvoytenko jridgewell
/to alanorozco camelburrito chenshay choumx cvializ ericlindley-g erwinmombay gregable honeybadgerdontcare jridgewell kmh287 lannka mkhatib mrjoro muxin newmuis powdercloud zhouyx
For any issues please file a bug at https://github.com/google/github-owners-bot/issues |
cb30681 to
3c45442
Compare
| if (win.AMP_CONFIG | ||
| && Array.isArray(win.AMP_CONFIG['allow-url-opt-in']) | ||
| && win.AMP_CONFIG['allow-url-opt-in'].length > 0) { | ||
| const allowed = win.AMP_CONFIG['allow-url-opt-in']; |
* master: (34 commits) Prevent amp-carousel next/previous icons fade away on desktop (ampproject#8428) Turn on flag slidescroll-disable-css-snap” (ampproject#8436) Revert "temporarily turn off yarn (ampproject#8356)" (ampproject#8384) initial commit (ampproject#8404) Upgrades for Index Exchange amp-ad tags to report load statistics (ampproject#8054) amp-bind validation tweak (ampproject#8414) Fix an amp-instagram race condition (ampproject#8192) Use whitelist to restrict urlReplacement for scoped analytics element (ampproject#8360) Report active experiments in error logs (ampproject#8108) amp-bind: Catch exceptions in mutatedAttributesCallback (ampproject#8383) Fixing custom scroll-snap on IOS (ampproject#8391) Add experiment for using AmpContext class in integration.js (ampproject#8348) add (ampproject#8349) swipe api (ampproject#8357) skip 3 flaky tests (ampproject#8388) amp-bind: Expression complexity limit (ampproject#8321) add margin-bottom (ampproject#8350) Flying carpet: make container full viewport and center content (ampproject#8292) Service Registration: Document Click (ampproject#7882) Add a8ad (ampproject#8036) ...
* Move URL experiment overrides into toggles * Test that URL overrides cookies * Add experiments to error reports * Use custom format * lint * lint * Fix tests * Fix experiments hash * Fix test * Ensure AMP_EXP is reset when resetting toggles * lint * Move pump-early-frame into allow-url-opt-in
Fixes #7484.