Skip to content

Hide progress bar on the control group of auto advance experiment#38215

Merged
powerivq merged 1 commit intoampproject:mainfrom
powerivq:hide-the-progress-bar
May 19, 2022
Merged

Hide progress bar on the control group of auto advance experiment#38215
powerivq merged 1 commit intoampproject:mainfrom
powerivq:hide-the-progress-bar

Conversation

@powerivq
Copy link
Copy Markdown
Contributor

The behavior of the current main branch incidentally changed when refactoring the progress bar. This PR will revert that change, and will:

  • Hide the progress bar when the ad is shown.

@amp-owners-bot amp-owners-bot bot requested a review from raxsha May 19, 2022 06:06
@amp-owners-bot
Copy link
Copy Markdown

Hey @gmajoulet, @newmuis! These files were changed:

extensions/amp-story/1.0/amp-story-system-layer.css
extensions/amp-story/1.0/progress-bar.js

@powerivq powerivq requested review from calebcordry and mszylkowski and removed request for raxsha May 19, 2022 06:30
@powerivq powerivq merged commit f606447 into ampproject:main May 19, 2022
@powerivq powerivq deleted the hide-the-progress-bar branch May 19, 2022 17:47
westonruter added a commit that referenced this pull request May 20, 2022
…a-menu-images-validator-spec

* 'main' of github.com:ampproject/amphtml: (90 commits)
  🔥 [Story mediapool] Fix videos from mediapool with `noaudio` don't have audio when reused. (#38216)
  Hide progress bar on the control group of auto advance experiment (#38215)
  ✨ Add Bento Autocomplete Component (#37837)
  🌐 [Story subscription] Subscription localization async (#38204)
  Dable: add new optional parameter "channel" (#38199)
  ✨ [AMP Story Paywall] Enable developers to specify a custom subscriptions page index (#38175)
  SwG Release 0.1.22.217 (#38187)
  amp-script: implements new size limits for sandboxed scripts (#38185)
  🖍  Hide the system layer and progress bar in preview mode (#38163)
  added minItems (#38177)
  Prevent expandTemplate from ReDOSing (#38178)
  Change amp-story-subscriptions attribute name to reflect its flexibility (#38176)
  🐛 [Story Preview] Enable amp-video to play in preview mode (#38149)
  Added the possibility to get page count to story messaging api (#38170)
  SwG Release 0.1.22.216 (#38168)
  Allow @newmuis to update OWNERS files (#38169)
  ✨ Add Richaudience to RTC callout vendors (#38160)
  🚀  SunMedia: Update amp-ad (#38128)
  Remove option to deploy PR artifacts to a static website (#38152)
  added some vars and requests in gfksensic.json (#37722)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants