added some vars and requests in gfksensic.json#37722
added some vars and requests in gfksensic.json#37722alanorozco merged 10 commits intoampproject:mainfrom dimitarandonov:vendor/gfk-sensic
Conversation
|
|
|
Hi, I hope someone is able to look at this PR soon. We would like to get this merged as soon as possible. Any feedback is appreciated. |
|
Hi, we are currently blocking some of our clients. Can you give some feedback if everything is ok or not with this pull request? We would like to get this merged as soon as possible. |
|
Hi @alanorozco, We need to have this as soon as possible to enable our clients to use the AMP integration properly. Can you please let us know if we missed anything to get this PR reviewed? |
|
Hi @alanorozco , We need to have this as soon as possible to enable our clients to use the AMP integration properly. Can you please let us know if we missed anything to get this PR reviewed? |
4 similar comments
|
Hi @alanorozco , We need to have this as soon as possible to enable our clients to use the AMP integration properly. Can you please let us know if we missed anything to get this PR reviewed? |
|
Hi @alanorozco , We need to have this as soon as possible to enable our clients to use the AMP integration properly. Can you please let us know if we missed anything to get this PR reviewed? |
|
Hi @alanorozco , We need to have this as soon as possible to enable our clients to use the AMP integration properly. Can you please let us know if we missed anything to get this PR reviewed? |
|
Hi @alanorozco , We need to have this as soon as possible to enable our clients to use the AMP integration properly. Can you please let us know if we missed anything to get this PR reviewed? |
|
Hi @powerivq @processprocess @alanorozco, @dmanek, @caroqliu , @rbeckthomas . we are waiting for review and we are totally puzzeled since nothing happens for 2 month now. What are we doing wrong? anything missing? |
alanorozco
left a comment
There was a problem hiding this comment.
Thank you for your PR and your patience. Approved.
…a-menu-images-validator-spec * 'main' of github.com:ampproject/amphtml: (90 commits) 🔥 [Story mediapool] Fix videos from mediapool with `noaudio` don't have audio when reused. (#38216) Hide progress bar on the control group of auto advance experiment (#38215) ✨ Add Bento Autocomplete Component (#37837) 🌐 [Story subscription] Subscription localization async (#38204) Dable: add new optional parameter "channel" (#38199) ✨ [AMP Story Paywall] Enable developers to specify a custom subscriptions page index (#38175) SwG Release 0.1.22.217 (#38187) amp-script: implements new size limits for sandboxed scripts (#38185) 🖍 Hide the system layer and progress bar in preview mode (#38163) added minItems (#38177) Prevent expandTemplate from ReDOSing (#38178) Change amp-story-subscriptions attribute name to reflect its flexibility (#38176) 🐛 [Story Preview] Enable amp-video to play in preview mode (#38149) Added the possibility to get page count to story messaging api (#38170) SwG Release 0.1.22.216 (#38168) Allow @newmuis to update OWNERS files (#38169) ✨ Add Richaudience to RTC callout vendors (#38160) 🚀 SunMedia: Update amp-ad (#38128) Remove option to deploy PR artifacts to a static website (#38152) added some vars and requests in gfksensic.json (#37722) ...
No description provided.