Compiler: Add amp-carousel-0.1 to the builder map#37308
Merged
samouri merged 3 commits intoampproject:mainfrom Jan 7, 2022
Merged
Compiler: Add amp-carousel-0.1 to the builder map#37308samouri merged 3 commits intoampproject:mainfrom
samouri merged 3 commits intoampproject:mainfrom
Conversation
rcebulko
approved these changes
Jan 6, 2022
| }, | ||
| '0.1': { | ||
| 'amp-fit-text': ampFitTextClassic, | ||
| 'amp-carousel': ampCarouselClassic1, |
Contributor
There was a problem hiding this comment.
ampCarouselClassic1 thanks I hate it 😆
d3fe056 to
9ec8efb
Compare
rcebulko
reviewed
Jan 7, 2022
0b7247b to
cb0f1e7
Compare
rcebulko
approved these changes
Jan 7, 2022
| * @param {{index: string, total: string}} options - The default title to use for the previous button. | ||
| */ | ||
| export function getNextButtonTitle(element, options = {}) { | ||
| export function getNextButtonTitle(element, options) { |
Contributor
There was a problem hiding this comment.
nit: If you end up with any other changes, may as well destructure the args here and getPrevButtonTitle like you do in getButtonTitle. If not, w/e
Suggested change
| export function getNextButtonTitle(element, options) { | |
| export function getNextButtonTitle(element, {index, total}) { |
westonruter
added a commit
that referenced
this pull request
Jan 10, 2022
…nce-attr-to-hero-img * 'main' of github.com:ampproject/amphtml: (525 commits) mathml storybook: supply missing component definition. (#37326) storybook: Iframe --> BentoIframe (#37327) 🖍 [Story system layer] New ad badge (#37311) 🐛 [amp story] Replay/next page button bug fix (#37316) 🚀 [Story performance] Remove affiliate links (#37280) Compiler: Add amp-carousel-0.1 to the builder map (#37308) ⏪ [Story system layer] Audio icon disappears when story has background audio (#37314) 🚀 [Story performance] Remove story access (#37281) Fix remapping esbuild output on Windows (#37312) 🐛 adds in correct weight for amp-story-product-tag text (#37188) typechecking carousel: remove shame files (#37213) Use remapping to remap minified sourcemap into source code (#37238) SwG Release 0.1.22.199 (#37310) 🐛 Adds microsoft-edge protocol (#34168) Sync for validator cpp engine and cpp htmlparser (#37292) ✨ amp-story-shopping Updated currency with product price and correct Localized currency (#37249) ✨[Smartadserver ad extension] Implement support for Fast Fetch (#36991) Remove client-side-experiments-config.json from this repo (#37304) 🚮 Remove closure compiler logic from build-system. (#37296) 🌐 Added RTL ordering i18n for amp story shopping tag (#37252) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
A necessary step for ssring
amp-carouselis adding it to the builder map.