Skip to content

✨ amp-story-shopping Updated currency with product price and correct Localized currency#37249

Merged
jshamble merged 24 commits intoampproject:mainfrom
jshamble:shoppingInternationalizationCurrency
Jan 5, 2022
Merged

✨ amp-story-shopping Updated currency with product price and correct Localized currency#37249
jshamble merged 24 commits intoampproject:mainfrom
jshamble:shoppingInternationalizationCurrency

Conversation

@jshamble
Copy link
Copy Markdown
Contributor

@jshamble jshamble commented Dec 21, 2021

closes #37126

Result:
Screen Shot 2021-12-29 at 2 43 33 PM

@amp-owners-bot amp-owners-bot bot requested a review from gmajoulet December 21, 2021 02:03
@amp-owners-bot
Copy link
Copy Markdown

amp-owners-bot bot commented Dec 21, 2021

Hey @gmajoulet! These files were changed:

extensions/amp-story-shopping/0.1/amp-story-shopping-tag.js
extensions/amp-story-shopping/0.1/test/test-amp-story-shopping-config.js
extensions/amp-story-shopping/0.1/test/test-amp-story-shopping-tag.js
extensions/amp-story/1.0/amp-story-store-service.js

Hey @newmuis! These files were changed:

extensions/amp-story/1.0/amp-story-store-service.js

@jshamble jshamble changed the title ✨ amp-story-shopping Updated Currency with Product price and correct Localized currency ✨ amp-story-shopping Updated currency with product price and correct Localized currency Dec 21, 2021
Copy link
Copy Markdown
Contributor

@processprocess processprocess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

@jshamble jshamble requested review from jridgewell and removed request for coreymasanto and gmajoulet January 5, 2022 20:24
Copy link
Copy Markdown
Contributor

@jridgewell jridgewell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Owners

@jshamble jshamble merged commit 09cb7c2 into ampproject:main Jan 5, 2022
westonruter added a commit that referenced this pull request Jan 10, 2022
…nce-attr-to-hero-img

* 'main' of github.com:ampproject/amphtml: (525 commits)
  mathml storybook: supply missing component definition. (#37326)
  storybook: Iframe --> BentoIframe (#37327)
  🖍  [Story system layer] New ad badge (#37311)
  🐛 [amp story] Replay/next page button bug fix (#37316)
  🚀  [Story performance] Remove affiliate links (#37280)
  Compiler: Add amp-carousel-0.1 to the builder map (#37308)
  ⏪  [Story system layer] Audio icon disappears when story has background audio (#37314)
  🚀  [Story performance] Remove story access (#37281)
  Fix remapping esbuild output on Windows (#37312)
  🐛 adds in correct weight for amp-story-product-tag text (#37188)
  typechecking carousel: remove shame files (#37213)
  Use remapping to remap minified sourcemap into source code (#37238)
  SwG Release 0.1.22.199 (#37310)
  🐛 Adds microsoft-edge protocol (#34168)
  Sync for validator cpp engine and cpp htmlparser (#37292)
  ✨ amp-story-shopping Updated currency with product price and correct Localized currency (#37249)
  ✨[Smartadserver ad extension] Implement support for Fast Fetch (#36991)
  Remove client-side-experiments-config.json from this repo (#37304)
  🚮  Remove closure compiler logic from build-system. (#37296)
  🌐 Added RTL ordering i18n for amp story shopping tag (#37252)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[amp story shopping] Currency i18n

4 participants