Revert: "amp-layout: extract buildDOM #compiler (#34770)"#35146
Merged
samouri merged 1 commit intoampproject:mainfrom Jul 7, 2021
Merged
Revert: "amp-layout: extract buildDOM #compiler (#34770)"#35146samouri merged 1 commit intoampproject:mainfrom
samouri merged 1 commit intoampproject:mainfrom
Conversation
alanorozco
approved these changes
Jul 7, 2021
Contributor
|
cc @jridgewell for OWNERS |
jridgewell
approved these changes
Jul 7, 2021
Contributor
|
Fixes #35154 (Filed this for tracking the CP) |
samouri
added a commit
that referenced
this pull request
Jul 13, 2021
…Dom extraction (#35148) * static-layout: extract getEffectiveLayout * Revert "Revert: "amp-layout: extract buildDOM #compiler (#34770)" (#35146)" This reverts commit f3b1875. * amp-layout should use getEffectiveLayout * lint * Update src/builtins/amp-layout/amp-layout.js Co-authored-by: Ryan Cebulko <ryan@cebulko.com> * extract typedef for EffectiveLayout * make wrapper func with smaller API return * move cached return * empty commit Co-authored-by: Ryan Cebulko <ryan@cebulko.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
Reverts the meaningful changes from #34770.
The root cause of the issue was that
parseLayoutis not equivalent tothis.getLayout().parseLayout()just ensures the input layout type is valid and returns aLayoutthis.getLayout()would use the "effective layout" calculated by callingapplyStaticLayout.