amp-layout: extract buildDOM #compiler#34770
Merged
samouri merged 1 commit intoampproject:mainfrom Jun 29, 2021
Merged
Conversation
Member
Author
|
Blocked on #34681. Not because this is actually blocked...but just to save Ryan the hassle of dealing with merge conflicts on that jumbo PR |
cffafa5 to
fae1950
Compare
Contributor
That PR is unblocked. Thank you for saving the headache 😃 |
fae1950 to
fe24971
Compare
rcebulko
approved these changes
Jun 15, 2021
Contributor
rcebulko
left a comment
There was a problem hiding this comment.
It's cool that this is so straightforward now
Member
Author
|
@jridgewell for OWNERS approval |
Member
Author
|
Friendly 🏓 to @jridgewell |
Contributor
|
Edit: nope, he said next week, it's others who are OOO |
jridgewell
approved these changes
Jun 29, 2021
samouri
added a commit
that referenced
this pull request
Jul 7, 2021
samouri
added a commit
that referenced
this pull request
Jul 13, 2021
…Dom extraction (#35148) * static-layout: extract getEffectiveLayout * Revert "Revert: "amp-layout: extract buildDOM #compiler (#34770)" (#35146)" This reverts commit f3b1875. * amp-layout should use getEffectiveLayout * lint * Update src/builtins/amp-layout/amp-layout.js Co-authored-by: Ryan Cebulko <ryan@cebulko.com> * extract typedef for EffectiveLayout * make wrapper func with smaller API return * move cached return * empty commit Co-authored-by: Ryan Cebulko <ryan@cebulko.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
Extracts
buildDOMfrombuildCallbackso that it can be called separate from the rest of init (for server render).