📖 [Amp story] [Page attachments] Amp.dev Docs for New Page Attachment Features#34883
Closed
raxsha wants to merge 12 commits intoampproject:mainfrom
Closed
📖 [Amp story] [Page attachments] Amp.dev Docs for New Page Attachment Features#34883raxsha wants to merge 12 commits intoampproject:mainfrom
raxsha wants to merge 12 commits intoampproject:mainfrom
Conversation
|
Hey @gmajoulet, @newmuis! These files were changed: |
| A UI prompt to open the attachment will automatically be added at the bottom of every page that configured an attachment. | ||
| Story page attachments allow you to provide additional content in the form of inline AMPHTML content on specific AMP story pages. This content can be revealed by users through a "swipe up" gesture, or a tap on bottom of the page. A UI button guiding the viewer to open the attachment will appear at the bottom of every page with a `amp-story-page-attachment` element. | ||
|
|
||
| <amp-img alt="AMP Story page attachment" layout="fixed" src="https://github.com/ampproject/amphtml/raw/main/extensions/amp-story/img/amp-story-page-attachment.gif" width="240" height="480"> |
Contributor
There was a problem hiding this comment.
We need to update this gif to show the new UI.
|
|
||
| String that represents the color theme, default is light. Accepts values `light` & `dark`. | ||
|
|
||
|  |
Contributor
There was a problem hiding this comment.
This example includes image attributes. We probably don't want to show an image like this until the cta-image & cta-image-2 section.
Let's use an image that is the default UI but with dark theme here.
In that way the reader won't have to try and figure out why it looks different with the dark squares.
Update attributes to follow pattern of other documentation.
change img to image.
change guide to prompt.
Add "It must have the `layout="nodisplay"` attribute."
Contributor
|
Closing so it can be pushed to from a new branch #35338 |
processprocess
added a commit
that referenced
this pull request
Aug 2, 2021
… Features #34883 (#35338) * new page attachment docs * Update amp-story-page-attachment.md Update attributes to follow pattern of other documentation. * Update amp-story-page-attachment.md change img to image. * Update amp-story-page-attachment.md change guide to prompt. * Update amp-story-page-attachment.md Add "It must have the `layout="nodisplay"` attribute." * Update placement section. * Attribute edits. * Update amp-story-page-outlink.md * Update amp-story-page-attachment.md * Update amp-story-page-attachment.md * Update amp-story-page-outlink.md * update gif * Update gif * Update intro * Update png * Update pngs * update pngs * Update images to be consistent size. * Update linking * image sizing * Upadte images. * Update image * Remove dead link. * Update date. * Clarify image size. * Clarify image dimensions. Co-authored-by: Raksha Muthukumar <raksha.muth@gmail.com>
westonruter
added a commit
to westonruter/amphtml
that referenced
this pull request
Aug 3, 2021
…tok-validation * 'main' of github.com:ampproject/amphtml: (72 commits) build: run amp lint --fix to address import order of jixie (ampproject#35513) ✨ [amp-analytics] Add Custom Browser Event Tracker (ampproject#35193) babel: teach amp mode transformer about #core/mode (ampproject#35477) 🚮 Remove experiment `amp-consent-granular-consent` (ampproject#35508) ♻️ Enable auto-sorting+grouping within src/ and 3p/ (ampproject#35454) 🐛 [amp-render] fix root-element stripping from amp-render with amp-bind (ampproject#35449) ✅ [Story interactive] Add Example Story for Detailed Results Component (ampproject#35450) 🐛 Fix error on bento example (ampproject#35490) 🐛 amp-story-grid-layer: Fix AMP invalidation error in documentation (ampproject#35503) 🐛 Fix code formatting (ampproject#35499) ✅ buildDom: add tests for amp-fit-text and amp-layout (ampproject#35494) ♻️ Remove unused imports (ampproject#35435) ✨ amp-connatix-player: iframe domain based on a property (ampproject#35179) Updated document with use cases of remote config (ampproject#35496) AMP.goBack: update documentation (ampproject#29290) 🏗 Allow the bundle-size job to run even if the builds were skipped (ampproject#35492) build-system: improve terser/esbuild integration (ampproject#35466) 🧪 [Story performance] Disable animations on first page to 50% (ampproject#35476) 📖 [Amp story] [Page attachments] Amp.dev Docs for New Page Attachment Features ampproject#34883 (ampproject#35338) 🚀 [Story interactive] Rewrite Image URL to Cached URL for Image Quizzes and Polls (ampproject#35375) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding amp.dev documentation for the changes to AMP story page attachments:
amp-story-page-attachmentdocsamp-story-page-outlinkdocsMore info in I2S: #34449
Fixes #34790.