Skip to content

AMP.goBack: update documentation#29290

Merged
samouri merged 3 commits intoampproject:mainfrom
samouri:goback-docs
Aug 2, 2021
Merged

AMP.goBack: update documentation#29290
samouri merged 3 commits intoampproject:mainfrom
samouri:goback-docs

Conversation

@samouri
Copy link
Copy Markdown
Member

@samouri samouri commented Jul 15, 2020

Add documentation for the new navigate param. Last step before closing #5225

@samouri samouri requested a review from dreamofabear July 15, 2020 19:25
@amp-owners-bot amp-owners-bot bot requested a review from mrjoro July 15, 2020 19:25
@samouri samouri removed the request for review from mrjoro July 15, 2020 19:25
@samouri
Copy link
Copy Markdown
Member Author

samouri commented Aug 20, 2020

@choumx 🏓

@samouri samouri requested a review from dreamofabear August 25, 2020 16:19
@samouri
Copy link
Copy Markdown
Member Author

samouri commented Aug 25, 2020

@morsssss: since will is no longer with us (RIP), do you mind checking the prose for clarity?

@samouri samouri requested review from jridgewell and morsssss and removed request for dreamofabear August 25, 2020 16:21
@samouri samouri requested a review from morsssss August 26, 2020 15:56
@samouri samouri requested a review from morsssss August 31, 2020 16:35
@dreamofabear
Copy link
Copy Markdown

I think goBack(navigate=false) does navigate backwards across pages on publisher origin.

Did we verify this? I suppose we don't necessarily have to point out this edge case in documentation.

@samouri
Copy link
Copy Markdown
Member Author

samouri commented Aug 31, 2020

Did we verify this? I suppose we don't necessarily have to point out this edge case in documentation.

The usual dev server operates closer to origin than viewer right?
I've tested there and it definitely only navigates cross-document when navigate=true.

@samouri
Copy link
Copy Markdown
Member Author

samouri commented Aug 2, 2021

@morsssss 🏓

@samouri samouri requested a review from jridgewell August 2, 2021 16:31
@samouri samouri enabled auto-merge (squash) August 2, 2021 16:31
@samouri samouri dismissed morsssss’s stale review August 2, 2021 21:02

addressed feedback

@samouri samouri merged commit bcfb71e into ampproject:main Aug 2, 2021
@samouri samouri deleted the goback-docs branch August 2, 2021 22:08
westonruter added a commit to westonruter/amphtml that referenced this pull request Aug 3, 2021
…tok-validation

* 'main' of github.com:ampproject/amphtml: (72 commits)
  build: run amp lint --fix to address import order of jixie (ampproject#35513)
  ✨ [amp-analytics] Add Custom Browser Event Tracker (ampproject#35193)
  babel: teach amp mode transformer about #core/mode (ampproject#35477)
  🚮 Remove experiment `amp-consent-granular-consent` (ampproject#35508)
  ♻️ Enable auto-sorting+grouping within src/ and 3p/ (ampproject#35454)
  🐛  [amp-render] fix root-element stripping from amp-render with amp-bind (ampproject#35449)
  ✅ [Story interactive] Add Example Story for Detailed Results Component (ampproject#35450)
  🐛 Fix error on bento example (ampproject#35490)
  🐛 amp-story-grid-layer: Fix AMP invalidation error in documentation (ampproject#35503)
  🐛 Fix code formatting (ampproject#35499)
  ✅ buildDom: add tests for amp-fit-text and amp-layout (ampproject#35494)
  ♻️ Remove unused imports (ampproject#35435)
  ✨ amp-connatix-player: iframe domain based on a property (ampproject#35179)
  Updated document with use cases of remote config (ampproject#35496)
  AMP.goBack: update documentation (ampproject#29290)
  🏗 Allow the bundle-size job to run even if the builds were skipped (ampproject#35492)
  build-system: improve terser/esbuild integration (ampproject#35466)
  🧪 [Story performance] Disable animations on first page to 50% (ampproject#35476)
  📖 [Amp story] [Page attachments] Amp.dev Docs for New Page Attachment Features ampproject#34883 (ampproject#35338)
  🚀 [Story interactive] Rewrite Image URL to Cached URL for Image Quizzes and Polls (ampproject#35375)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants