Skip to content

Apply lang="en" in bulk to examples/#34836

Merged
caroqliu merged 1 commit intoampproject:mainfrom
caroqliu:bulk-transform-examples
Jun 15, 2021
Merged

Apply lang="en" in bulk to examples/#34836
caroqliu merged 1 commit intoampproject:mainfrom
caroqliu:bulk-transform-examples

Conversation

@caroqliu
Copy link
Copy Markdown
Contributor

This PR completes #34759 by applying lang="en" to all html tags, regardless of existing attributes. (The original approach used a naive find and replace on <html ⚡

@caroqliu caroqliu requested a review from alanorozco June 11, 2021 16:42
@caroqliu caroqliu enabled auto-merge (squash) June 11, 2021 20:20
@caroqliu caroqliu merged commit 3ace35c into ampproject:main Jun 15, 2021
westonruter added a commit to westonruter/amphtml that referenced this pull request Jun 16, 2021
…ebook-like-bento-version

* 'main' of github.com:ampproject/amphtml: (23 commits)
  `amp-story-desktop-one-panel` Update demo with usecases (ampproject#34867)
  🚮 Remove src/purifier.js rollup config (ampproject#34876)
  Validator Rollup (ampproject#34769)
  ✨ `amp-story-desktop-one-panel` Check UI type to get page dimension on tap (ampproject#34875)
  Refactor: move getRealChildNodes and getRealChildren to core (ampproject#34813)
  🏗📖 Fix some example files that do not validate (ampproject#34835)
  🏗Add `#test` and `#testing` to alias list (ampproject#34853)
  Add css files for missing components (ampproject#34861)
  Apply bulk transform to html tags (ampproject#34836)
  🐛 amp-ima-video: Fix duration label on livestreams (ampproject#34865)
  ♻️  Extract `applyFillContent` into a standalone function (ampproject#34858)
  Give script tag closing tag (ampproject#34832)
  🏗 Refinements to renovate config (ampproject#34862)
  Bento: Enable `SocialShare` for npm publishing (ampproject#34817)
  🏗 Use aliased paths in generated extensions (ampproject#34860)
  ✨ `amp-story-desktop-one-panel` Position distance="2" page below viewport (ampproject#34834)
  🏗 Set `wrapper` on generated Bento extensions (ampproject#34843)
  🧪[story-ads] Allow viewer to set progress bar segment experiment. (ampproject#34827)
  🏗 Allow extension bundles to specify their own wrapper (ampproject#34845)
  🏗🚀 Speed up validated example grouping ~45x (ampproject#34837)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants