Skip to content

🏗📖 Fix some example files that do not validate#34835

Merged
alanorozco merged 15 commits intoampproject:mainfrom
alanorozco:validate-html-fixture
Jun 15, 2021
Merged

🏗📖 Fix some example files that do not validate#34835
alanorozco merged 15 commits intoampproject:mainfrom
alanorozco:validate-html-fixture

Conversation

@alanorozco
Copy link
Copy Markdown
Member

@alanorozco alanorozco commented Jun 11, 2021

Partial for #25149.

  1. Fixes a set of documents.
  2. Removes unused example files that do not validate.
  3. Categorizes some ignore rules that cannot be removed.
  4. Adds a general rule for bento/ directories, for documents which are not meant to be valid.

@alanorozco alanorozco requested review from caroqliu and rsimha June 11, 2021 15:28
@alanorozco alanorozco changed the title 📖 Fix video-related example files that do not validate 📖 Fix some example files that do not validate Jun 11, 2021
@alanorozco alanorozco changed the title 📖 Fix some example files that do not validate 🏗📖 Fix some example files that do not validate Jun 11, 2021
Copy link
Copy Markdown
Contributor

@rsimha rsimha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing our test fixtures! LGTM with one logging change.

alanorozco and others added 5 commits June 15, 2021 09:48
@alanorozco alanorozco merged commit 0311689 into ampproject:main Jun 15, 2021
@alanorozco alanorozco deleted the validate-html-fixture branch June 15, 2021 19:56
westonruter added a commit to westonruter/amphtml that referenced this pull request Jun 16, 2021
…ebook-like-bento-version

* 'main' of github.com:ampproject/amphtml: (23 commits)
  `amp-story-desktop-one-panel` Update demo with usecases (ampproject#34867)
  🚮 Remove src/purifier.js rollup config (ampproject#34876)
  Validator Rollup (ampproject#34769)
  ✨ `amp-story-desktop-one-panel` Check UI type to get page dimension on tap (ampproject#34875)
  Refactor: move getRealChildNodes and getRealChildren to core (ampproject#34813)
  🏗📖 Fix some example files that do not validate (ampproject#34835)
  🏗Add `#test` and `#testing` to alias list (ampproject#34853)
  Add css files for missing components (ampproject#34861)
  Apply bulk transform to html tags (ampproject#34836)
  🐛 amp-ima-video: Fix duration label on livestreams (ampproject#34865)
  ♻️  Extract `applyFillContent` into a standalone function (ampproject#34858)
  Give script tag closing tag (ampproject#34832)
  🏗 Refinements to renovate config (ampproject#34862)
  Bento: Enable `SocialShare` for npm publishing (ampproject#34817)
  🏗 Use aliased paths in generated extensions (ampproject#34860)
  ✨ `amp-story-desktop-one-panel` Position distance="2" page below viewport (ampproject#34834)
  🏗 Set `wrapper` on generated Bento extensions (ampproject#34843)
  🧪[story-ads] Allow viewer to set progress bar segment experiment. (ampproject#34827)
  🏗 Allow extension bundles to specify their own wrapper (ampproject#34845)
  🏗🚀 Speed up validated example grouping ~45x (ampproject#34837)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants