♿ Apply lang="en" to relevant snippets in extensions/#34766
Merged
caroqliu merged 4 commits intoampproject:mainfrom Jun 9, 2021
Merged
♿ Apply lang="en" to relevant snippets in extensions/#34766caroqliu merged 4 commits intoampproject:mainfrom
lang="en" to relevant snippets in extensions/#34766caroqliu merged 4 commits intoampproject:mainfrom
Conversation
|
Hey @ampproject/wg-caching! These files were changed: Hey @gmajoulet! These files were changed: Hey @processprocess! These files were changed: Hey @t0mg! These files were changed: Hey @mszylkowski! These files were changed: Hey @newmuis! These files were changed: |
honeybadgerdontcare
approved these changes
Jun 8, 2021
This was referenced Jun 8, 2021
Member
|
I'm not opposed, but these are all test files for validator, not examples. They aren't documentation (tests are partially documentation, but not in the way this is being applied). You've already made the changes, so go ahead, but I would recommend saving the trouble in future cases of this. |
Contributor
Author
Thanks for the recommendation—I tend to agree and will keep an eye out for similar changes in the future that may not be worth the trouble. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a partial copy of #31208, which adds
lang="en"to relevant code snippets in this codebase. Instead of copying the PR file-for-file, I decided to break this change up into a few root directories for ease of review and less likelihood of falling behind to merge conflicts. /to @banaag who approved the original PROriginal PR description:
Others in the series: #34757 #34758 #34759
/cc @TetraLogicalHelpdesk