♿ Add lang="en" to relevant snippets in build-system/#34757
Merged
caroqliu merged 1 commit intoampproject:mainfrom Jun 9, 2021
Merged
♿ Add lang="en" to relevant snippets in build-system/#34757caroqliu merged 1 commit intoampproject:mainfrom
build-system/#34757caroqliu merged 1 commit intoampproject:mainfrom
Conversation
|
Hey @alanorozco! These files were changed: |
This was referenced Jun 8, 2021
Contributor
kristoferbaxter
left a comment
There was a problem hiding this comment.
These files are used by AMP developers working on the library itself?
Contributor
Author
Yes. In particular, the templates for the |
Contributor
|
Changing them all makes sense, just wanted to make sure I understood where the value was. Thanks! |
kristoferbaxter
approved these changes
Jun 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is a partial copy of #31208, which adds
lang="en"to relevant code snippets in this codebase. Instead of copying the PR file-for-file, I decided to break this change up into a few root directories for ease of review and less likelihood of falling behind to merge conflicts.Original PR description:
/cc @TetraLogicalHelpdesk