♿ Add missing lang attributes to examples#4972
Merged
matthiasrohmer merged 2 commits intoampproject:futurefrom Nov 18, 2020
TetraLogical:tetralogical-documentation-phase1
Merged
♿ Add missing lang attributes to examples#4972matthiasrohmer merged 2 commits intoampproject:futurefrom TetraLogical:tetralogical-documentation-phase1
matthiasrohmer merged 2 commits intoampproject:futurefrom
TetraLogical:tetralogical-documentation-phase1
Conversation
`disabled` attribute makes the demos pointless as they can't be operated, so the presumed keyboard interaction can't be seen. added generic image `alt` attributes
|
|
Collaborator
|
LGTM on my end. @caroqliu to review |
matthiasrohmer
approved these changes
Nov 18, 2020
robinvanopstal
added a commit
that referenced
this pull request
Nov 19, 2020
* future: Update dependency rcs-core to v3.5.1 (#4957) Translation pt br - Finding the Right Component (#4956) Update dependency sass-loader to v10.1.0 (#4954) 🚸 Provide better user feedback for unspecified content-types (#4959) Update dependency copy-webpack-plugin to v6.3.1 (#4964) better click behavior (#4967) Create teachers@es.md (#4971) Translation ES - beginning-course (#4969) ♿ Add missing lang attributes to examples (#4972) Fix invalid example (#4974) Update dependency marked to v1.2.4 (#4968)
Collaborator
|
looks like this removed the |
Contributor
|
oh goodness, you're right. an embarassing find/replace snafu on my part. I'll open a separate PR to fix that |
Collaborator
|
no worries whatsoever! already macroed up #5026 to update them. just commenting for posterity (p.s. HI @patrickhlauke !!!!!!!!!!!!!!!!!!) |
Contributor
sent you a DM on twitter the other week when I saw you comment on #4973 (comment) (but you're likely not on that often anymore these days) 👍 |
This was referenced Jun 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Suggested changes and additions based on the TetraLogical accessibility review commissioned by @nainar / @caroqliu
x-ref ampproject/amphtml#31208