Skip to content

better click behavior#4967

Merged
matthiasrohmer merged 1 commit intoampproject:futurefrom
Meghpal:future
Nov 18, 2020
Merged

better click behavior#4967
matthiasrohmer merged 1 commit intoampproject:futurefrom
Meghpal:future

Conversation

@Meghpal
Copy link
Copy Markdown
Contributor

@Meghpal Meghpal commented Nov 14, 2020

The sidebar toggle on click/focus outlines only the label-icon:

14

I improved the click behavior to encompass the whole label:

24

GIFs from Chrome

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Nov 14, 2020

CLA assistant check
All committers have signed the CLA.

@matthiasrohmer matthiasrohmer merged commit ccf3820 into ampproject:future Nov 18, 2020
robinvanopstal added a commit that referenced this pull request Nov 19, 2020
* future:
  Update dependency rcs-core to v3.5.1 (#4957)
  Translation pt br - Finding the Right Component (#4956)
  Update dependency sass-loader to v10.1.0 (#4954)
  🚸  Provide better user feedback for unspecified content-types (#4959)
  Update dependency copy-webpack-plugin to v6.3.1 (#4964)
  better click behavior (#4967)
  Create teachers@es.md (#4971)
  Translation ES - beginning-course (#4969)
  ♿  Add missing lang attributes to examples (#4972)
  Fix invalid example (#4974)
  Update dependency marked to v1.2.4 (#4968)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants