Skip to content

🏗 Restore package-lock.json to lockfileVersion = 1#33222

Merged
rsimha merged 1 commit intoampproject:masterfrom
rsimha:2021-03-11-FixLockfile
Mar 11, 2021
Merged

🏗 Restore package-lock.json to lockfileVersion = 1#33222
rsimha merged 1 commit intoampproject:masterfrom
rsimha:2021-03-11-FixLockfile

Conversation

@rsimha
Copy link
Copy Markdown
Contributor

@rsimha rsimha commented Mar 11, 2021

The lockfile currently checked in was generated by a version of npm that did not ship with the LTS version of node. (Separate check coming up to make sure the lockfile is of the correct version.)

@rsimha rsimha requested a review from jridgewell March 11, 2021 22:12
@rsimha rsimha self-assigned this Mar 11, 2021
@rsimha rsimha requested review from micajuine-ho and powerivq March 11, 2021 22:13
@rsimha rsimha merged commit 2f932e6 into ampproject:master Mar 11, 2021
@rsimha rsimha deleted the 2021-03-11-FixLockfile branch March 11, 2021 22:35
westonruter added a commit to westonruter/amphtml that referenced this pull request Mar 15, 2021
* 'master' of github.com:ampproject/amphtml: (536 commits)
  ✨ Send extension versions from AMPHTML ads to FIE  (ampproject#33190)
  Update amp-autocomplete test output file (ampproject#33216)
  ✨ Changing Inline Page Attachment Button UI  (ampproject#33142)
  ✨Launch no-signing (ampproject#33229)
  ♻️ Add logic for story ad page manager. (ampproject#33201)
  Migrate Bento components to V1 (ampproject#32974)
  📦 Update dependency mocha to v8.3.2 (ampproject#33234)
  📦 Update build system devDependencies (ampproject#33178)
  🧪 [amp-consent] Turn on TCF PostMessage Proxy API Experiment (ampproject#33196)
  Fix amp-video amp_video_quality parameter name. (ampproject#33227)
  🏗 Guard access to `BASH_ENV` during CircleCI push builds (ampproject#33231)
  🏗 Clean up CircleCI merge SHA logic (ampproject#33215)
  📦 Update dependency karma to v6.1.2 (ampproject#33151)
  🏗 Ensure up-to-date and clean `package-lock.json` before running any CI job (ampproject#33223)
  Ensure that pre-stubbing always happens before the first element is upgraded (ampproject#33212)
  🏗 Restore `package-lock.json` to `lockfileVersion = 1` (ampproject#33222)
  Fixed text align of buttons (ampproject#33217)
  [amp-story] ♿ Add label for next story and add i18n for pagination buttons (ampproject#33205)
  [amp-story-player] 📖  Rename skip-next control to skip-to-next (ampproject#33164)
  🚀 Report cls-fcp and cls-vis to compare with cls (ampproject#33207)
  ...
muuki88 pushed a commit to highfivve/amphtml that referenced this pull request Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants