[amp-story-player] 📖 Rename skip-next control to skip-to-next#33164
Merged
Enriqe merged 2 commits intoampproject:masterfrom Mar 11, 2021
Merged
[amp-story-player] 📖 Rename skip-next control to skip-to-next#33164Enriqe merged 2 commits intoampproject:masterfrom
Enriqe merged 2 commits intoampproject:masterfrom
Conversation
|
Hey @gmajoulet, @newmuis! These files were changed: |
gmajoulet
approved these changes
Mar 9, 2021
Contributor
|
🥇 |
fac73be to
cb278f7
Compare
cb278f7 to
b0ad3b2
Compare
Contributor
Author
|
@samouri can we get owners approval for |
samouri
approved these changes
Mar 11, 2021
Member
samouri
left a comment
There was a problem hiding this comment.
Approval for src/localized-strings
westonruter
added a commit
to westonruter/amphtml
that referenced
this pull request
Mar 15, 2021
* 'master' of github.com:ampproject/amphtml: (536 commits) ✨ Send extension versions from AMPHTML ads to FIE (ampproject#33190) Update amp-autocomplete test output file (ampproject#33216) ✨ Changing Inline Page Attachment Button UI (ampproject#33142) ✨Launch no-signing (ampproject#33229) ♻️ Add logic for story ad page manager. (ampproject#33201) Migrate Bento components to V1 (ampproject#32974) 📦 Update dependency mocha to v8.3.2 (ampproject#33234) 📦 Update build system devDependencies (ampproject#33178) 🧪 [amp-consent] Turn on TCF PostMessage Proxy API Experiment (ampproject#33196) Fix amp-video amp_video_quality parameter name. (ampproject#33227) 🏗 Guard access to `BASH_ENV` during CircleCI push builds (ampproject#33231) 🏗 Clean up CircleCI merge SHA logic (ampproject#33215) 📦 Update dependency karma to v6.1.2 (ampproject#33151) 🏗 Ensure up-to-date and clean `package-lock.json` before running any CI job (ampproject#33223) Ensure that pre-stubbing always happens before the first element is upgraded (ampproject#33212) 🏗 Restore `package-lock.json` to `lockfileVersion = 1` (ampproject#33222) Fixed text align of buttons (ampproject#33217) [amp-story] ♿ Add label for next story and add i18n for pagination buttons (ampproject#33205) [amp-story-player] 📖 Rename skip-next control to skip-to-next (ampproject#33164) 🚀 Report cls-fcp and cls-vis to compare with cls (ampproject#33207) ...
muuki88
pushed a commit
to highfivve/amphtml
that referenced
this pull request
Mar 15, 2021
…ject#33164) * s/skip-next/skip-to-next * prettier
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames control name for more clarity, including backwards compatibility with the old name.