babel tests: support windows#30165
Merged
samouri merged 4 commits intoampproject:masterfrom Sep 10, 2020
Merged
Conversation
|
Hey @erwinmombay, @jridgewell! These files were changed: |
rsimha
reviewed
Sep 9, 2020
Contributor
rsimha
left a comment
There was a problem hiding this comment.
Thanks for fixing these. For maintainability, I've suggested some changes that may or may not work. WDYT?
build-system/babel-plugins/babel-plugin-transform-inline-configure-component/index.js
Outdated
Show resolved
Hide resolved
build-system/babel-plugins/babel-plugin-amp-mode-transformer/index.js
Outdated
Show resolved
Hide resolved
Member
Author
|
Leaving this in a half-broken state right now. Will ping back tomorrow when its ready for another round |
jridgewell
reviewed
Sep 10, 2020
build-system/babel-plugins/babel-plugin-transform-jss/create-hash.js
Outdated
Show resolved
Hide resolved
Member
Author
|
@rsimha / @jridgewell: updated, PTAL |
rsimha
approved these changes
Sep 10, 2020
Contributor
rsimha
left a comment
There was a problem hiding this comment.
Thanks for the fix. Glad we had these tests to detect problems on Windows.
ed-bird
pushed a commit
to ed-bird/amphtml
that referenced
this pull request
Dec 10, 2020
* babel tests: support windows * nocked a few via posix * simplify fn * lint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
Followup to #29115.
Make the babel tests pass on Windows. There were two main items I found that needed updating:
pathmodule functions in for strings meant to be the the "from" in ImportDeclarations. JS modules need to be posix-style.amphtml. Technically the git repo can be a folder with any name.