amp-list: Fix layoutCallback promise chain in SSR path#29726
Merged
dreamofabear merged 1 commit intoampproject:masterfrom Aug 6, 2020
Merged
amp-list: Fix layoutCallback promise chain in SSR path#29726dreamofabear merged 1 commit intoampproject:masterfrom
dreamofabear merged 1 commit intoampproject:masterfrom
Conversation
samouri
approved these changes
Aug 6, 2020
Member
samouri
left a comment
There was a problem hiding this comment.
Whoops 😬 . Nice catch. How did we get alerted to the issue?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a regression in #25964 which causes
amp-list[layout=container]to have zero height during render (with SSR).This is caused by
firstLayoutCompleted() -> togglePlaceholder(false)before render of real children finishes, which causes thelayout=containeramp-list to lose its height (defined by its placeholder) have itsheightstyle locked to 0.