🐛 Fix amp-list race condition#25964
Merged
dreamofabear merged 10 commits intoampproject:masterfrom Jan 3, 2020
Merged
Conversation
Member
Author
|
@choumx / @jridgewell: 🏓 |
dreamofabear
approved these changes
Dec 16, 2019
jridgewell
reviewed
Dec 17, 2019
sparhami
pushed a commit
to sparhami/amphtml
that referenced
this pull request
Jan 3, 2020
* amp-list: bail out of rendering updates if the src has changed in the meantime * Add test * add test * more specific test * remove only * no need to return promise (jridgewell) * cleaner test case with a more explicit wait * remove Promise again * whitespace * lint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
Addresses #25961
Adds a check that the
srchas not changed while the xhr was inflight. If thesrchas changed, then bail instead of scheduling a render. I've added a test that previously would have resulted in two renders and now instead only has one.cc @jridgewell / @choumx