Adding dock support for Brid player#26877
Conversation
|
Hey @ampproject/wg-caching, these files were changed:
|
honeybadgerdontcare
left a comment
There was a problem hiding this comment.
validation changes look good
alanorozco
left a comment
There was a problem hiding this comment.
Could you first push AD_START and AD_END events?
Otherwise users cannot interact with the ad when docked:
When implemented correctly, you get a back-to-inline button:
|
Thank you for the feedback @alanorozco. Just added several events that were missing in our player (ENDED, AD_START, AD_END, LOADEDMETADATA). Note that there's a small issue with these dock controls and prerolls. Here's the scenario:
Basically, dock extension won't update controls on ad started before player entered the dock mode at least once. |
alanorozco
left a comment
There was a problem hiding this comment.
This change seems fine for this component, let's merge.
@grajzer Re: the state race issue with AD_START, it seems like a legitimate bug at the amp-video-docking level. Could you please file a bug separately?
* master: (54 commits) inabox-resources: Minor test improvement (ampproject#26916) DocInfo: replace metaTags with viewport in API (ampproject#26687) 🐛 SwG now uses AMP sendBeacon interface (ampproject#26970) 🏗 Allow array destructuring on preact hooks (ampproject#26901) Gulp Dep Check: fail on unused entries (ampproject#26981) Update no-import lint rule to forbid sub-paths (ampproject#26531) 🐛 amp-ad type blade - fix bladeOnLoad callback (ampproject#26627) 📖 Clarify when max-age is required (ampproject#26956) ♻️ Consolidate players as .i-amphtml-media-component (ampproject#26967) Add Preact Enzyme tests (ampproject#26529) Fixes `update_tests` flag on `gulp validator` (ampproject#26965) 📦 Update dependency google-closure-library to v20200224 (ampproject#26986) 🏗 Transform aliased configured components (ampproject#26541) ✨ InaboxResources: Observe intersections for some elements' viewportCallbacks (ampproject#26942) variable substitutions: Support allowlist lookup in AmpDocShadow (ampproject#26731) cl/297197875 Revision bump for ampproject#26877 (ampproject#26982) Json fix (ampproject#26971) 📦 Update dependency mocha to v7.1.0 (ampproject#26976) Add documentation for amp-access-scroll (ampproject#26782) make controls always shown in amp for email (ampproject#25714) ...
No description provided.