🐛 amp-ad type blade - fix bladeOnLoad callback#26627
🐛 amp-ad type blade - fix bladeOnLoad callback#26627gmajoulet merged 4 commits intoampproject:masterfrom
Conversation
gershman
commented
Feb 5, 2020
- fix function: createContainer - bug: global was undefined fix: move function to be under the main export function
|
@lannka Hi I see that the build didn't pass, I don't think it something related to my pull request. Can you help? |
|
The test failure seems to be a flake. Restarted. |
|
@lannka hi when will this be merge and deployed ? |
|
@lannka ? |
|
@lannka @gmajoulet @erwinmombay |
|
I restarted the failing tests, if they still don't pass, could you please sync your PR with the master branch? |
|
@lannka @gmajoulet @erwinmombay - Hi, I merged from master and rerun the tests, they still failed. So, I run gulp pr-check vs master branch and the same test fails there. |
|
I restarted them ~5 times but they keep failing for different reasons. :( Can someone from @ampproject/wg-infra chime in? |
Do you have failure logs, or remember which tests failed? (Restarted build means I can't see the old ones.) /cc @zhouyx who is build cop this week, and can help with skipping any obviously flaky tests. |
|
Looks like all test passed. Happy to skip tests if flakiness continues. |
|
If this occurs again, could you stick the logs in a Gist and comment? That will help us debug. There is a known issue where we're hitting Sauce Labs concurrency limits, which may have been the culprit here. |
|
Looks like cc'ing the infra people scared the flaky tests away, thanks all :)) |
* master: (54 commits) inabox-resources: Minor test improvement (ampproject#26916) DocInfo: replace metaTags with viewport in API (ampproject#26687) 🐛 SwG now uses AMP sendBeacon interface (ampproject#26970) 🏗 Allow array destructuring on preact hooks (ampproject#26901) Gulp Dep Check: fail on unused entries (ampproject#26981) Update no-import lint rule to forbid sub-paths (ampproject#26531) 🐛 amp-ad type blade - fix bladeOnLoad callback (ampproject#26627) 📖 Clarify when max-age is required (ampproject#26956) ♻️ Consolidate players as .i-amphtml-media-component (ampproject#26967) Add Preact Enzyme tests (ampproject#26529) Fixes `update_tests` flag on `gulp validator` (ampproject#26965) 📦 Update dependency google-closure-library to v20200224 (ampproject#26986) 🏗 Transform aliased configured components (ampproject#26541) ✨ InaboxResources: Observe intersections for some elements' viewportCallbacks (ampproject#26942) variable substitutions: Support allowlist lookup in AmpDocShadow (ampproject#26731) cl/297197875 Revision bump for ampproject#26877 (ampproject#26982) Json fix (ampproject#26971) 📦 Update dependency mocha to v7.1.0 (ampproject#26976) Add documentation for amp-access-scroll (ampproject#26782) make controls always shown in amp for email (ampproject#25714) ...