Skip to content

amp-script: Create 'fill content' container for responsive/fluid#26400

Merged
dreamofabear merged 2 commits intoampproject:masterfrom
dreamofabear:script-sizer-bug
Jan 23, 2020
Merged

amp-script: Create 'fill content' container for responsive/fluid#26400
dreamofabear merged 2 commits intoampproject:masterfrom
dreamofabear:script-sizer-bug

Conversation

@dreamofabear
Copy link
Copy Markdown

@dreamofabear dreamofabear commented Jan 18, 2020

Fixes illegal resizing for "responsive" and "fluid" layouts.

@samouri
Copy link
Copy Markdown
Member

samouri commented Jan 23, 2020

Is there an associated Issue / how did we figure out about this?

@dreamofabear dreamofabear marked this pull request as ready for review January 23, 2020 16:53
@dreamofabear
Copy link
Copy Markdown
Author

I was fixing another bug and noticed this. :|

@dreamofabear dreamofabear requested a review from samouri January 23, 2020 18:08
@dreamofabear dreamofabear merged commit 49823f3 into ampproject:master Jan 23, 2020
@dreamofabear dreamofabear deleted the script-sizer-bug branch January 23, 2020 21:24
robinvanopstal added a commit to jungvonmatt/amphtml that referenced this pull request Jan 27, 2020
* master: (62 commits)
  📦 Update dependency fetch-mock to v8.3.2 (ampproject#26491)
  Revert 'Move mutator implementations out to a standalone service' (ampproject#26479)
  Fix syntax error (ampproject#26481)
  Add pespective back. (ampproject#26486)
  More user friendly errors in layout.js (ampproject#26448)
  ✨ Start logging AMP URL on SwG Pages (ampproject#26480)
  Fix border around desktop amp-story-pages. (ampproject#26449)
  Fix Story tests. (ampproject#26464)
  ✨ Performance Measurement Chrome Extension (ampproject#26333)
  amp-consent restrict iframe fullScreen if no focus  (ampproject#26461)
  Add performance benchmark task (ampproject#26026)
  ♻️ amp-script: emit warning if zero height and width. (ampproject#26444)
  ✨ Launch minimal-wrapper native CEv1 (ampproject#26360)
  ♻️ Lint: include externs (round 2) (ampproject#26446)
  amp-script: Create 'fill content' container for responsive/fluid (ampproject#26400)
  amp-consent remove cmp iframe focus (ampproject#26437)
  Disable macro-after-long-task in inabox. (ampproject#26459)
  Launch layoutbox-invalidate-on-scroll (ampproject#26430)
  Add amp-ad support for ByPlay (ampproject#25663)
  🏗 Add specific RTV opt-in to experiments.html (ampproject#26434)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants