✨ Allow crossorigin=anonymous on Scripts#25291
Merged
honeybadgerdontcare merged 7 commits intoampproject:masterfrom Oct 30, 2019
Merged
✨ Allow crossorigin=anonymous on Scripts#25291honeybadgerdontcare merged 7 commits intoampproject:masterfrom
honeybadgerdontcare merged 7 commits intoampproject:masterfrom
Conversation
|
Hey @ampproject/wg-caching, these files were changed:
|
1 similar comment
|
Hey @ampproject/wg-caching, these files were changed:
|
Contributor
Author
|
@honeybadgerdontcare: I corrected the other test to include your nit message. |
honeybadgerdontcare
approved these changes
Oct 29, 2019
amaltas
added a commit
that referenced
this pull request
Nov 5, 2019
amaltas
added a commit
that referenced
this pull request
Nov 5, 2019
micajuine-ho
pushed a commit
to micajuine-ho/amphtml
that referenced
this pull request
Dec 27, 2019
* Allow crossorigin=anonymous on Scripts Fixes ampproject#24731 * Add tests * nit * nit .out file * nits * nit: alphabetical * nit: alphabetical
micajuine-ho
pushed a commit
to micajuine-ho/amphtml
that referenced
this pull request
Dec 27, 2019
* cl/277925913 Revision bump for ampproject#25291 * cl/277925913 Revision bump for ampproject#25291 * cl/278402306 Remove unused CSS selector code * cl/278620720 Revision bump for ampproject#25210 * cl/278642597 Revision bump for ampproject#24793 * cl/278653831 Revision bump for ampproject#25425 * Fix merge issues in original rollup commit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a necessary step in order to fix error reporting for errors generated by crossorigin scripts. Making the script
anonymoussignals to the browser that there is no User PII in the script, and will allow the errors to be generated will full stack trace and error message.Fixes #24731