🐛 Recognize data-amp-bind-src as mandatory_anyof alternative to [src] in amp-list#24793
Merged
twifkak merged 3 commits intoampproject:masterfrom Nov 4, 2019
Merged
Conversation
|
Hey @ampproject/wg-caching, these files were changed:
|
Gregable
approved these changes
Sep 30, 2019
|
Hey @ampproject/wg-caching, these files were changed:
|
Member
|
It looks like you need to update this one test output file as described here: |
|
Hey @ampproject/wg-caching, these files were changed:
|
Member
Author
|
Can this be merged? |
Member
|
Yup! Done. |
amaltas
added a commit
that referenced
this pull request
Nov 5, 2019
Member
Author
|
When will this be live? It's been over 2 weeks since merging, so I expected it to be in the validator now. |
Contributor
|
@westonruter It is live but there is an implementation issue here. I'm looking into why and it may be due to how we special case You can see that it's live by going to validator.amp.dev. |
Contributor
|
@westonruter a fix has been submitted and should be out within a week. |
micajuine-ho
pushed a commit
to micajuine-ho/amphtml
that referenced
this pull request
Dec 27, 2019
… in amp-list (ampproject#24793) Include 'data-amp-bind-src' in mandatory_anyof alongside '[src]'
micajuine-ho
pushed a commit
to micajuine-ho/amphtml
that referenced
this pull request
Dec 27, 2019
* cl/277925913 Revision bump for ampproject#25291 * cl/277925913 Revision bump for ampproject#25291 * cl/278402306 Remove unused CSS selector code * cl/278620720 Revision bump for ampproject#25210 * cl/278642597 Revision bump for ampproject#24793 * cl/278653831 Revision bump for ampproject#25425 * Fix merge issues in original rollup commit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #24661.
The AMP validator then is flagging use of
data-amp-bind-srcinstead of[src], when only the former is being used onamp-list. This is marked as an error because of thismandatory_anyofconstraint:amphtml/extensions/amp-list/validator-amp-list.protoascii
Line 93 in 8c7a612
A quick fix here would be to just add
data-amp-bind-srcto the list:Per @Gregable this is sufficient rather than making the validator aware of the
data-amp-bind-*alternate attribute syntax.