Upgrade node from ^10.0.0 to ^12.0.0#25161
Conversation
| "main": "index.js", | ||
| "engines": { | ||
| "node": "^10.0.0", | ||
| "node": "^12.0.0", |
There was a problem hiding this comment.
To increase resiliency, it might be worth allowing the current and the next LTS version (^12 || ^14) in a future PR.
There was a problem hiding this comment.
Some developers reported on slack they are no longer able to use amphtml-validator with nodejs 10.0. And they cannot upgrade to 12.0 soon.
Can we update this to support >=10.0 ?
Sorry, I do not have much background about this upgrade.
There was a problem hiding this comment.
+1 if feasible. FWIW, v10 is still considered "active LTS" until 2020-04-01 and not EOL until 2021-04-30 per https://nodejs.org/en/about/releases/
There was a problem hiding this comment.
It sounds reasonable to support all currently Active LTS versions (as of today, 10 and 12). So maybe this should be ^10 || ^12 || ^14?
(This is different from >= 10 because we want to skip major versions that will never be an LTS version.)
There was a problem hiding this comment.
PR here for >=10.0.0, could update to the suggestion above. #25208
There was a problem hiding this comment.
To build future resiliency, we can have renovate auto-update the engines section of all our package.json files: https://docs.renovatebot.com/node/
I'll file a tracking issue. Edit: Filed #25209 to track this.
| "@jridgewell/resorcery": "0.0.3", | ||
| "acorn-globals": "4.3.4", | ||
| "amphtml-validator": "1.0.26", | ||
| "amphtml-validator": "1.0.23", |
There was a problem hiding this comment.
@honeybadgerdontcare Any concerns with rolling back temporarily?
|
Thank you Esther!!!! |
To match node v12 being the active LTS version as of 10/21/19: https://nodejs.org/en/about/releases/