Support node v10, v12, or v14 for amphtml-validator#25208
Merged
rsimha merged 3 commits intoampproject:masterfrom Oct 22, 2019
Merged
Support node v10, v12, or v14 for amphtml-validator#25208rsimha merged 3 commits intoampproject:masterfrom
rsimha merged 3 commits intoampproject:masterfrom
Conversation
twifkak
approved these changes
Oct 22, 2019
Member
twifkak
left a comment
There was a problem hiding this comment.
LGTM on behalf of @ampproject/wg-caching.
cc @cpapazian
Contributor
|
Force merging this to unblock #25188. |
Member
|
This was published as https://www.npmjs.com/package/amphtml-validator version 1.0.28. |
|
any plans to support node 8.x? Next.js use it vercel/next.js#9172 |
joshuarrrr
pushed a commit
to Parsely/amphtml
that referenced
this pull request
Oct 23, 2019
Contributor
Node 8 support was restored with #25278 and #25279, and should be available with |
micajuine-ho
pushed a commit
to micajuine-ho/amphtml
that referenced
this pull request
Dec 27, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.