🐛Adds responsive layout support to amp-soundcloud#23148
Merged
sparhami merged 7 commits intoampproject:masterfrom Jul 23, 2019
Merged
🐛Adds responsive layout support to amp-soundcloud#23148sparhami merged 7 commits intoampproject:masterfrom
sparhami merged 7 commits intoampproject:masterfrom
Conversation
Contributor
|
|
Gregable
reviewed
Jul 2, 2019
Member
Gregable
left a comment
There was a problem hiding this comment.
Validator changes look good.
|
I think it would be worth expanding this to use Lines 149 to 159 in 1366241 For example, |
sparhami
suggested changes
Jul 8, 2019
sparhami
left a comment
There was a problem hiding this comment.
Left a comment, I think we should change to isLayoutSizeDefined.
sparhami
suggested changes
Jul 20, 2019
sparhami
approved these changes
Jul 22, 2019
rindo
pushed a commit
to logly/amphtml
that referenced
this pull request
Jul 24, 2019
* Added support for all size defining layouts to amp-soundcloud and fixed some examples
Merged
Gregable
pushed a commit
that referenced
this pull request
Jul 25, 2019
* cl/258377914 Revision bump for #23122 * cl/258634966 Revision bump for #23349 * cl/258870451 Fix incorrect allowance of `<form method="get">` with relative URLs * cl/259565186 Revision bump for #23386 * cl/259587993 Add a descriptive comment to amp-carousel rules. * cl/259661215 Fix #23012 by removing the dispatch key on amp-carousel type=carousel. * cl/259662509 Revision bump for #23148 * cl/259988931 Revision bump for #23482
Member
|
FYI: The WordPress plugin is applying this change to have 100% visual parity in the SoundCloud embed blocks between AMP and non-AMP: ampproject/amp-wp#3003 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #23144
Changes
responsivelayout a valid prop