🐛 Avoid redirects inside amp-access-poool iframe on click events#23122
🐛 Avoid redirects inside amp-access-poool iframe on click events#23122jpettitt merged 12 commits intoampproject:masterfrom
Conversation
Co-Authored-By: Ugo Stephant <ugo@poool.fr>
…attributes Co-Authored-By: Ugo Stephant <ugo@poool.fr>
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the ℹ️ Googlers: Go here for more info. |
|
/cc @jpettitt @dvoytenko |
extensions/amp-access-poool/validator-amp-access-poool.protoascii
Outdated
Show resolved
Hide resolved
jpettitt
left a comment
There was a problem hiding this comment.
LGTM once Greg's validator question is resolved
|
@dackmin can you figure out which one of you the CLA bot doesn't like, I can override for the PR since I know you've signed it but it would be nice if we could stop it doing this. |
|
@jpettitt would love to 😂 If I'm not mistaking, looking at the commit status @NicolasAuger is being rekt by the bot everytime he pushes, despite having signed the CLAs and pushing commits with the same email. Is there anything more we can do/check to avoid that? Maybe adding a |
|
At a guess there is a commit way back in the history that doesn't have a cla |
Co-Authored-By: Ugo Stephant <ugo@poool.fr>
after poool attr-lists addition Co-Authored-By: Ugo Stephant <ugo@poool.fr>
|
@dackmin here is what the bot is seeing . |
|
@jpettitt we noticed @NicolasAuger pushed some commits a while back using his @ynov.com email and we added it as secondary email for his @poool.fr one. It now shows up on the CLAs dashboard, is it enough for future PRs or does the bot need some additional actions from us? |
|
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
|
It's saying "CLAs are signed, but unable to verify author consent" I'm not sure quite what that means. Since you have both signed I've manually set it as OK and merged your commit. |
…project#23122) * fix(amp-access-poool): handle clicks event from inside paywall iframe Co-Authored-By: Ugo Stephant <ugo@poool.fr> * fix(amp-access-poool): add validator definition for amp-access-poool attributes Co-Authored-By: Ugo Stephant <ugo@poool.fr> * fix(amp-access-poool): fix typo in validator test not updated in output file * fix(amp-access-poool): fix validator rules Co-Authored-By: Ugo Stephant <ugo@poool.fr> * tests(amp-access-poool): update common-extension-attrs spec index after poool attr-lists addition Co-Authored-By: Ugo Stephant <ugo@poool.fr>
* cl/258377914 Revision bump for #23122 * cl/258634966 Revision bump for #23349 * cl/258870451 Fix incorrect allowance of `<form method="get">` with relative URLs * cl/259565186 Revision bump for #23386 * cl/259587993 Add a descriptive comment to amp-carousel rules. * cl/259661215 Fix #23012 by removing the dispatch key on amp-carousel type=carousel. * cl/259662509 Revision bump for #23148 * cl/259988931 Revision bump for #23482
Fixes #23121
Also fixes missing validator rules for
poool-access-previewandpoool-access-contentattributes.