✨amp-experiment 1.0: Added a 15KB limit on amp-experiment JSON#22372
Merged
torch2424 merged 1 commit intoampproject:masterfrom May 20, 2019
Merged
✨amp-experiment 1.0: Added a 15KB limit on amp-experiment JSON#22372torch2424 merged 1 commit intoampproject:masterfrom
torch2424 merged 1 commit intoampproject:masterfrom
Conversation
Member
|
This looks as though it has the potential to break existing pages with >15KB on them already. Has anyone yet looked to see if that's a potential risk, or do you need me to run that analysis? (If the latter, this will be next week). |
Contributor
Author
|
@Gregable Thank you for bringing this up! 😄
Could we run the analysis if you don't mind? This isn't super high priority or anything, so next week is fine 😄 👍 Thanks! |
Contributor
Author
|
@Gregable Confirmed this should not break anyone (Data is from last month though). But since the old JSON format wasn't very verbose, I think we are fine. This is good for another review 😄 |
Gregable
approved these changes
May 20, 2019
Contributor
Author
alin04
added a commit
to alin04/amphtml
that referenced
this pull request
May 21, 2019
Merged
alin04
added a commit
that referenced
this pull request
May 21, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relates to #20225
relates to #21705
relates to #22168
This adds a 15KB limit to the amp-experiment JSON. See the discussion in #22168 for the reasoning. It Was decided offline to add an additional 5KB, since different variants will be input that don't affect the mutation limit. 😄
This is done all through the validator, and updated the test file accordingly 👍
cc @Gregable for the validator review
cc @zhouyx for the "concept" review haha! 😂