Add validation rules for <amp-ad-custom>#22289
Merged
lannka merged 3 commits intoampproject:masterfrom May 14, 2019
Merged
Conversation
honeybadgerdontcare
approved these changes
May 14, 2019
| # limitations under the license. | ||
|
|
||
| tags: { # amp-ad-custom | ||
| html_format: AMP # Ads are not allowed inside ads |
Contributor
There was a problem hiding this comment.
I'd update the comment to be # AMP only as ads are not allowed inside AMP Ads
| attr_lists: "common-extension-attrs" | ||
| } | ||
| tags: { # <amp-ad-custom> | ||
| html_format: AMP # Ads are not allowed inside ads |
alin04
pushed a commit
to alin04/amphtml
that referenced
this pull request
May 21, 2019
Merged
alin04
added a commit
that referenced
this pull request
May 21, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #22280