Skip to content

Restore OriginExperiments#20248

Merged
dreamofabear merged 10 commits intoampproject:masterfrom
dreamofabear:restore-origin-experiments
Jan 11, 2019
Merged

Restore OriginExperiments#20248
dreamofabear merged 10 commits intoampproject:masterfrom
dreamofabear:restore-origin-experiments

Conversation

@dreamofabear
Copy link
Copy Markdown

@dreamofabear dreamofabear commented Jan 10, 2019 •
edited
Loading

Fixes #16183.

Follow-ups:

  • Convert OriginExperiments to a doc service.
  • Stop using parseUrlDeprecated.
  • Write usage instructions for generating keys etc.

@dreamofabear
Copy link
Copy Markdown
Author

dreamofabear commented Jan 10, 2019

/to @alabiaga @mrjoro

@mrjoro
Copy link
Copy Markdown
Member

mrjoro commented Jan 10, 2019

Woo! Is this just a restoration of the code that was there before?

@dreamofabear
Copy link
Copy Markdown
Author

dreamofabear commented Jan 10, 2019

@mrjoro There are some minor changes to reflect new code landscape (commits past the first).

@dreamofabear
Copy link
Copy Markdown
Author

dreamofabear commented Jan 10, 2019 •
edited
Loading

Looks like this causes a dependency cycle in the --single_pass build:

AssertionError [ERR_ASSERTION]: Node src/services.js forms circular dependency: 
extensions/amp-list/0.1/amp-list.js
 -> src/batched-json.js
 -> src/services.js
 -> src/element-service.js
 -> src/service.js
 -> src/polyfills.js
 -> src/experiments.js
 -> src/services.js

@dreamofabear dreamofabear merged commit bf15984 into ampproject:master Jan 11, 2019
@dreamofabear dreamofabear deleted the restore-origin-experiments branch January 11, 2019 16:03
noranazmy pushed a commit to noranazmy/amphtml that referenced this pull request Mar 22, 2019
Restore OriginExperiments (ampproject#20248)
27d5274 
* Revert "Remove unused OriginExperiments (ampproject#15220)"

This reverts commit a0a1136.

* Pass AmpDoc to get PWA-supported head node.

* parseUrl is deprecated.

* (1/2) Move code from experiments.js to origin-experiments.js.

* (2/2) Move remaining code to OriginExperiments and make it a service.

* Move service getter to origin-experiments-impl.js to avoid v0.js bundling.

* Rewrite tests.

* Use url service instead of parseUrlDeprecated.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrjoro mrjoro mrjoro approved these changes

+1 more reviewer

@alabiaga alabiaga alabiaga approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes PR use: In Stable

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dreamofabear @mrjoro @alabiaga @googlebot @ampprojectbot