Remove unused OriginExperiments#15220
Merged
dreamofabear merged 4 commits intoampproject:masterfrom May 11, 2018
Merged
Conversation
jridgewell
approved these changes
May 11, 2018
|
|
||
| const runtimeFile = './dist/v0.js'; | ||
| const maxSize = '77.76KB'; | ||
| const maxSize = '77.68KB'; |
Contributor
There was a problem hiding this comment.
Man, all that was only .12KB?
dreamofabear
pushed a commit
to dreamofabear/amphtml
that referenced
this pull request
Jan 10, 2019
This reverts commit a0a1136.
dreamofabear
pushed a commit
that referenced
this pull request
Jan 11, 2019
* Revert "Remove unused OriginExperiments (#15220)" This reverts commit a0a1136. * Pass AmpDoc to get PWA-supported head node. * parseUrl is deprecated. * (1/2) Move code from experiments.js to origin-experiments.js. * (2/2) Move remaining code to OriginExperiments and make it a service. * Move service getter to origin-experiments-impl.js to avoid v0.js bundling. * Rewrite tests. * Use url service instead of parseUrlDeprecated.
noranazmy
pushed a commit
to noranazmy/amphtml
that referenced
this pull request
Mar 22, 2019
* Revert "Remove unused OriginExperiments (ampproject#15220)" This reverts commit a0a1136. * Pass AmpDoc to get PWA-supported head node. * parseUrl is deprecated. * (1/2) Move code from experiments.js to origin-experiments.js. * (2/2) Move remaining code to OriginExperiments and make it a service. * Move service getter to origin-experiments-impl.js to avoid v0.js bundling. * Rewrite tests. * Use url service instead of parseUrlDeprecated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A lesson in YAGNI. Reduces bundle-size by 0.07KB.
/to @jridgewell