✨maximum-nights attribute on amp-date-picker#19854
Merged
cvializ merged 5 commits intoampproject:masterfrom Dec 13, 2018
Merged
✨maximum-nights attribute on amp-date-picker#19854cvializ merged 5 commits intoampproject:masterfrom
cvializ merged 5 commits intoampproject:masterfrom
Conversation
Contributor
honeybadgerdontcare
left a comment
There was a problem hiding this comment.
validation changes look good
Contributor
Author
|
Thanks for checking @honeybadgerdontcare! |
alanorozco
approved these changes
Dec 13, 2018
Contributor
Author
|
Thanks for the review @alanorozco 📝 |
cathyxz
pushed a commit
to cathyxz/amphtml
that referenced
this pull request
Dec 17, 2018
* Implement maximum-nights feature in range amp-date-picker * Refactor wrapper into wrapper folder * Add validator rules for maximum-nights * Add integration test 🤞 no flakes * Add updated validator test out
Merged
honeybadgerdontcare
added a commit
that referenced
this pull request
Dec 19, 2018
* cl/225092847 Add validator rules for amp-video and amp-yotpo in EXPERIMENTAL. * cl/225106151 "add validator changes to support script templates -alabiaga@" * cl/225388113 Revision bump for #19854 * cl/225400099 Revision bump for #19871 * cl/225612473 Remove EXPERIMENTAL from amp-list and amp-state. * cl/225861155 Revision bump for #19872 * cl/225872246 Revision bump for #19894 * cl/225876987 Revision bump for #18700 * cl/226048698 Revision bump for #19928 * cl/226051527 Revision bump for #18440
bramanudom
pushed a commit
to bramanudom/amphtml
that referenced
this pull request
Dec 19, 2018
* cl/225092847 Add validator rules for amp-video and amp-yotpo in EXPERIMENTAL. * cl/225106151 "add validator changes to support script templates -alabiaga@" * cl/225388113 Revision bump for ampproject#19854 * cl/225400099 Revision bump for ampproject#19871 * cl/225612473 Remove EXPERIMENTAL from amp-list and amp-state. * cl/225861155 Revision bump for ampproject#19872 * cl/225872246 Revision bump for ampproject#19894 * cl/225876987 Revision bump for ampproject#18700 * cl/226048698 Revision bump for ampproject#19928 * cl/226051527 Revision bump for ampproject#18440
noranazmy
pushed a commit
to noranazmy/amphtml
that referenced
this pull request
Mar 22, 2019
* Implement maximum-nights feature in range amp-date-picker * Refactor wrapper into wrapper folder * Add validator rules for maximum-nights * Add integration test 🤞 no flakes * Add updated validator test out
noranazmy
pushed a commit
to noranazmy/amphtml
that referenced
this pull request
Mar 22, 2019
* cl/225092847 Add validator rules for amp-video and amp-yotpo in EXPERIMENTAL. * cl/225106151 "add validator changes to support script templates -alabiaga@" * cl/225388113 Revision bump for ampproject#19854 * cl/225400099 Revision bump for ampproject#19871 * cl/225612473 Remove EXPERIMENTAL from amp-list and amp-state. * cl/225861155 Revision bump for ampproject#19872 * cl/225872246 Revision bump for ampproject#19894 * cl/225876987 Revision bump for ampproject#18700 * cl/226048698 Revision bump for ampproject#19928 * cl/226051527 Revision bump for ampproject#18440
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19702.
Feature is implemented as a wrapper React component to implement modularly. The wrapper folder doesn't contain the other wrapper classes yet, like
withFocusedTrueHackbut this will be done in a future refactor to simplify the other classes.