✨ Implement new amp-access-poool extension#18700
Merged
jpettitt merged 60 commits intoampproject:masterfrom Dec 17, 2018
p3ol:amp-access-poool
Merged
✨ Implement new amp-access-poool extension#18700jpettitt merged 60 commits intoampproject:masterfrom p3ol:amp-access-poool
jpettitt merged 60 commits intoampproject:masterfrom
p3ol:amp-access-poool
Conversation
|
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) |
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
dvoytenko
approved these changes
Dec 5, 2018
Contributor
|
LGTM on my side. Thanks! |
|
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) |
Contributor
|
@dackmin @NicolasAuger your PR is now merged. Congrats on your new extension. Due to the holiday code freeze it won't make it to production until some time in January. Look for the "In Canary" and "In Production" labels on this PR to track status. Once it hits canary you will be able to test it in the real world using the dev channel setting at https://cdn.ampproject.org/experiments.html |
cathyxz
pushed a commit
to cathyxz/amphtml
that referenced
this pull request
Dec 17, 2018
* feat: start amp-access-poool, amp-acces based component * feat: wip poool vendor implementation * fix: add needed pingback method * feat: declare amp-access-poool in main bundle config file * feat: add article-access-poool example * feat: add poool config * feat: load poool script * feat: add poool-paywall section * styles: add component style file * chore: add amp-access-poool validator * feat: add itemID as amp-access-poool param * feat: add mandatory params checking before processing * fix: fix missing dev/user log method * feat: render poool method * fix: import missing methods * feat: poool authorization * tests: amp-access-poool test file * docs: amp-access-poool documentation * refactor: ensure that amp reader id is set in poool config * tests: poool access/paywall tests * docs: update documentation * refactor: clean code * docs: update amp-access-poool doc * refactor: remove not needed test * tests: remove useless expect * docs: remove old config userIsPremium * fix: remove access rules on article preview * refactor: update unlock process * fix: fix amp access poool json config * refactor: set prod api url for authorization * fix: disable popover * refactor: remove unwanted config param * feat: wip amp-access-poool iframe * feat: working poool in iframe - Need reauthorize after release * feat(wip): iframe resizing * refactor: clean old css * refactor: iframe position and size * refactor: manage unlock widget behavior * fix: fix typo causing check-type test to fail * fix: fix comments * fix: fix typo * refactor: remove css file * refactor: replace local urls * fix: fix wrong api protocol * fix: missing addParamsToUrl & getMode * fix: fix wrong prop type * fix: fix addParamsToUrl method params * fix: fix addParamsToUrl params * fix: fix check-types issues * fix: missing trailing comma
Merged
honeybadgerdontcare
added a commit
that referenced
this pull request
Dec 19, 2018
* cl/225092847 Add validator rules for amp-video and amp-yotpo in EXPERIMENTAL. * cl/225106151 "add validator changes to support script templates -alabiaga@" * cl/225388113 Revision bump for #19854 * cl/225400099 Revision bump for #19871 * cl/225612473 Remove EXPERIMENTAL from amp-list and amp-state. * cl/225861155 Revision bump for #19872 * cl/225872246 Revision bump for #19894 * cl/225876987 Revision bump for #18700 * cl/226048698 Revision bump for #19928 * cl/226051527 Revision bump for #18440
bramanudom
pushed a commit
to bramanudom/amphtml
that referenced
this pull request
Dec 19, 2018
* feat: start amp-access-poool, amp-acces based component * feat: wip poool vendor implementation * fix: add needed pingback method * feat: declare amp-access-poool in main bundle config file * feat: add article-access-poool example * feat: add poool config * feat: load poool script * feat: add poool-paywall section * styles: add component style file * chore: add amp-access-poool validator * feat: add itemID as amp-access-poool param * feat: add mandatory params checking before processing * fix: fix missing dev/user log method * feat: render poool method * fix: import missing methods * feat: poool authorization * tests: amp-access-poool test file * docs: amp-access-poool documentation * refactor: ensure that amp reader id is set in poool config * tests: poool access/paywall tests * docs: update documentation * refactor: clean code * docs: update amp-access-poool doc * refactor: remove not needed test * tests: remove useless expect * docs: remove old config userIsPremium * fix: remove access rules on article preview * refactor: update unlock process * fix: fix amp access poool json config * refactor: set prod api url for authorization * fix: disable popover * refactor: remove unwanted config param * feat: wip amp-access-poool iframe * feat: working poool in iframe - Need reauthorize after release * feat(wip): iframe resizing * refactor: clean old css * refactor: iframe position and size * refactor: manage unlock widget behavior * fix: fix typo causing check-type test to fail * fix: fix comments * fix: fix typo * refactor: remove css file * refactor: replace local urls * fix: fix wrong api protocol * fix: missing addParamsToUrl & getMode * fix: fix wrong prop type * fix: fix addParamsToUrl method params * fix: fix addParamsToUrl params * fix: fix check-types issues * fix: missing trailing comma
bramanudom
pushed a commit
to bramanudom/amphtml
that referenced
this pull request
Dec 19, 2018
* cl/225092847 Add validator rules for amp-video and amp-yotpo in EXPERIMENTAL. * cl/225106151 "add validator changes to support script templates -alabiaga@" * cl/225388113 Revision bump for ampproject#19854 * cl/225400099 Revision bump for ampproject#19871 * cl/225612473 Remove EXPERIMENTAL from amp-list and amp-state. * cl/225861155 Revision bump for ampproject#19872 * cl/225872246 Revision bump for ampproject#19894 * cl/225876987 Revision bump for ampproject#18700 * cl/226048698 Revision bump for ampproject#19928 * cl/226051527 Revision bump for ampproject#18440
Contributor
Author
|
@dvoytenko @jpettitt any idea when this PR will be released in canary or production? |
Contributor
|
It's in production, has been since January. |
noranazmy
pushed a commit
to noranazmy/amphtml
that referenced
this pull request
Mar 22, 2019
* feat: start amp-access-poool, amp-acces based component * feat: wip poool vendor implementation * fix: add needed pingback method * feat: declare amp-access-poool in main bundle config file * feat: add article-access-poool example * feat: add poool config * feat: load poool script * feat: add poool-paywall section * styles: add component style file * chore: add amp-access-poool validator * feat: add itemID as amp-access-poool param * feat: add mandatory params checking before processing * fix: fix missing dev/user log method * feat: render poool method * fix: import missing methods * feat: poool authorization * tests: amp-access-poool test file * docs: amp-access-poool documentation * refactor: ensure that amp reader id is set in poool config * tests: poool access/paywall tests * docs: update documentation * refactor: clean code * docs: update amp-access-poool doc * refactor: remove not needed test * tests: remove useless expect * docs: remove old config userIsPremium * fix: remove access rules on article preview * refactor: update unlock process * fix: fix amp access poool json config * refactor: set prod api url for authorization * fix: disable popover * refactor: remove unwanted config param * feat: wip amp-access-poool iframe * feat: working poool in iframe - Need reauthorize after release * feat(wip): iframe resizing * refactor: clean old css * refactor: iframe position and size * refactor: manage unlock widget behavior * fix: fix typo causing check-type test to fail * fix: fix comments * fix: fix typo * refactor: remove css file * refactor: replace local urls * fix: fix wrong api protocol * fix: missing addParamsToUrl & getMode * fix: fix wrong prop type * fix: fix addParamsToUrl method params * fix: fix addParamsToUrl params * fix: fix check-types issues * fix: missing trailing comma
noranazmy
pushed a commit
to noranazmy/amphtml
that referenced
this pull request
Mar 22, 2019
* cl/225092847 Add validator rules for amp-video and amp-yotpo in EXPERIMENTAL. * cl/225106151 "add validator changes to support script templates -alabiaga@" * cl/225388113 Revision bump for ampproject#19854 * cl/225400099 Revision bump for ampproject#19871 * cl/225612473 Remove EXPERIMENTAL from amp-list and amp-state. * cl/225861155 Revision bump for ampproject#19872 * cl/225872246 Revision bump for ampproject#19894 * cl/225876987 Revision bump for ampproject#18700 * cl/226048698 Revision bump for ampproject#19928 * cl/226051527 Revision bump for ampproject#18440
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements a new
amp-access-pooolextension (see #18699)Please feel free to comment any line of that PR !