[amp-story] Allows inline json config for bookend and share providers ✨#19171
[amp-story] Allows inline json config for bookend and share providers ✨#19171gmajoulet merged 5 commits intoampproject:masterfrom
Conversation
915fac0 to
628bbd8
Compare
|
What happens if I specify a |
|
In I think we should avoid these hard dependencies. Unfortunately here, I don't know how we can keep amp-story-share / amp-story-bookend communication going through the store service. There are cases where we don't want to load the bookend configuration before actually preloading the bookend (mobile version on a phone that supports native sharing doesn't need to know about the share providers). Maybe we should refactor the
|
I was thinking that if both are specified then we'd want to prioritize the inline config so that we avoid doing unnecessary XHR's. But what you mention sounds like a better UX/devX.
Yeah, now that we think of the inline config as a fallback we can refactor the request service to get the inline config as a fallback when there's no I'll update the PR with these points taken into consideration. |
|
/cc @honeybadgerdontcare @Gregable for validation |
* cl/220306609 Revision bump for #17907 * cl/220307253 Revision bump for #19128 * cl/220310523 Revision bump for #19129 * cl/220399983 Revision bump for #19167 * cl/221145203 n/a * cl/221159765 Revision bump for #19214 * cl/221164382 Invalidate `<amp-script>` tag as well * cl/221176616 Revision bump for #17939 * cl/221181356 Revision bump for #19171
… ✨ (ampproject#19171) * allows inline json config for bookend and share providers * types, childjsoncofig * move logic to request service * move logic inline loadBookendConfigImpl * reviews
* cl/220306609 Revision bump for ampproject#17907 * cl/220307253 Revision bump for ampproject#19128 * cl/220310523 Revision bump for ampproject#19129 * cl/220399983 Revision bump for ampproject#19167 * cl/221145203 n/a * cl/221159765 Revision bump for ampproject#19214 * cl/221164382 Invalidate `<amp-script>` tag as well * cl/221176616 Revision bump for ampproject#17939 * cl/221181356 Revision bump for ampproject#19171
Closes #15826